Avoid repeating myself

Avoid repeating myself - javascript

I'm sure there is a way to write a shorter version of the following js code. In the end I'm just repeating myself over and over again. Any suggestions?
Thanks a lot!
if (designVal == 0 && colorVal == 0) {
design01yellow.style.display = "block";
design01black.style.display = "none";
design01blue.style.display = "none";
design01grey.style.display = "none";
design02yellow.style.display = "none";
design02black.style.display = "none";
design02blue.style.display = "none";
design02grey.style.display = "none";
design03yellow.style.display = "none";
design03black.style.display = "none";
design03blue.style.display = "none";
design03grey.style.display = "none";
} else if (designVal == 0 && colorVal == 1) {
design01yellow.style.display = "none";
design01black.style.display = "block";
design01blue.style.display = "none";
design01grey.style.display = "none";
design02yellow.style.display = "none";
design02black.style.display = "none";
design02blue.style.display = "none";
design02grey.style.display = "none";
design03yellow.style.display = "none";
design03black.style.display = "none";
design03blue.style.display = "none";
design03grey.style.display = "none";
} else if (designVal == 0 && colorVal == 2) {
design01yellow.style.display = "none";
design01black.style.display = "none";
design01blue.style.display = "block";
design01grey.style.display = "none";
design02yellow.style.display = "none";
design02black.style.display = "none";
design02blue.style.display = "none";
design02grey.style.display = "none";
design03yellow.style.display = "none";
design03black.style.display = "none";
design03blue.style.display = "none";
design03grey.style.display = "none";
} else if
///AND SO ON

Give all the elements a common class (e.g. class="design"). Loop over them, setting them all to none, then set the specific element to block.
document.querySelectorAll(".design").forEach(el => el.style.display = "none");
if (designVal == 0 && colorVal == 0) {
design01yellow.style.display = "block";
} else if (designVal == 0 && colorVal == 1) {
design01black.style.display = "block";
} ...

I'd normalize them to 'display: none' and then only set the one you want to display: block.
if (designVal === 0) {
design01yellow.style.display = "none";
design01black.style.display = "none";
design01blue.style.display = "none";
design01grey.style.display = "none";
design02yellow.style.display = "none";
design02black.style.display = "none";
design02blue.style.display = "none";
design02grey.style.display = "none";
design03yellow.style.display = "none";
design03black.style.display = "none";
design03blue.style.display = "none";
design03grey.style.display = "none";
if(colorVal === 0) {
design01yellow.style.display = "block";
} else if (colorVal === 1) {
design01black.style.display = "block";
} else if (colorVal === 2) {
design01blue.style.display = "block";
}
// and so on
}

Related

How loop through HTML Elements

This code makes it so when the user clicks one of the colors (color1-4) it sets the CSS display property of all the shoes none except for the color that was clicked, whose display is set to block. The code looks dirty and an employer would not approve.
How would I go about making that a for loop, or otherwise make the code cleaner?
color2.addEventListener('click', () => {
shoe.style.display = "none";
shoe3.style.display = "none";
shoe5.style.display = "none";
shoe2.style.display = "block";
console.log('u removed it and added another');
});
color3.addEventListener('click', () => {
shoe.style.display = "none";
shoe3.style.display = "none";
shoe5.style.display = "none";
shoe2.style.display = "none";
shoe3.style.display = "block";
console.log('u removed it and added another');
});
color4.addEventListener('click', () => {
shoe.style.display = "none";
shoe3.style.display = "none";
shoe5.style.display = "none";
shoe3.style.display = "none";
shoe5.style.display = "block";
console.log('u removed it and added another');
});
color1.addEventListener('click', () => {
shoe.style.display = "block";
shoe2.style.display = "none";
shoe3.style.display = "none";
shoe4.style.display = "none";
shoe5.style.display = "none";
console.log('u removed it and added another');
});
color2.addEventListener('click', () => {
shoe.style.display = "none";
shoe3.style.display = "none";
shoe5.style.display = "none";
shoe2.style.display = "block";
console.log('u removed it and added another');
});

You need to make use of Array and a custom function to manipulate DOM elements, here is an basic example:
var shoes = [s1,s2,s3]; //DOM element arrays
colorShoe = (shoe) =>{
for(let i=0; i<shoes.length;i++){
if(shoes[i] === shoe){
//Handling style
}
}

Please check this and see if you can modify your code like the below:
const colorList = [color1, color2, color3]; // you can add more
const shoeList = [shoe1, shoe2, shoe3]; // you can add more
[color1, color2, color3].forEach((color, colorIndex) => {
color.addEventListener('click', () => {
shoeList.forEach((shoe, shoeIndex) => {
if (colorIndex === shoeIndex) {
shoe.style.display = "block";
} else {
shoe.style.display = "none";
}
});
});
});

You can do like this if you dun wan to use array . Just use window['var name'+the index number] then you can add the thing you wan to do on the back :D thank you : D
color3.addEventListener('click', () => {
for (var i = 1; i <= 5; i++) {
if (i == 3) shoe.style.display = "block";
else {
window['shoe'+i].style.display = "none";
}
}
console.log('u removed it and added another');
});
color4.addEventListener('click', () => {
for (var i = 1; i <= 5; i++) {
if (i == 4) shoe.style.display = "block";
else {
window['shoe'+i].style.display = "none";
}
}
console.log('u removed it and added another');
});
color1.addEventListener('click', () => {
for (var i = 1; i <= 5; i++) {
if (i == 1) shoe.style.display = "block";
else {
window['shoe'+i].style.display = "none";
}
}
console.log('u removed it and added another');
});

Cannot read property 'style' of null in three places

When I run my code it give me this error: TypeError: Cannot read property 'style' of null at onlyShowInput1H (/:673:42) at showInputH (/:995:9) at HTMLButtonElement.onclick (/:85:117
In more detail here is what code does:
user inputs 1-10 tasks in the 1st div user inputs 1-10 tasks in the 2nd div (stored in localStorage)
user inputs 1-10 tasks in the 3nd div(stored in localStorage)
A do list is displayed with all the inputs the user inputed(stored in localStorage)
This error is being displayed: TypeError: Cannot read property 'addEventListener' of undefined at /script.js:66:5 TypeError: Cannot read property 'style' of null at onlyShowInput1H (/ITHB.js:457:42) at showInputH (/ITHB.js:779:9) at HTMLButtonElement.onclick (/:85:104)
I think the second error is affecting my code, from saving the 21st input because it's not reading it
Here is a link to a plunker of my code: https://plnkr.co/edit/HbT4WKFpqQrW5Ikv?open=lib%2Fscript.js
And here is a code snippet (not of my entire code but the part that isn't working):
function showInputHText() {
document.getElementById("inputHText").style.display = "block";
}
/* START of show input functions */
/* START: hard show input functions */
function dontShowInput1H() {
document.getElementById("hard-block").style.display = "none";
}
function onlyShowInput1H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "none";
document.getElementById("toDo22").style.display = "none";
document.getElementById("data23").style.display = "none";
document.getElementById("toDo23").style.display = "none";
document.getElementById("data24").style.display = "none";
document.getElementById("toDo24").style.display = "none";
document.getElementById("data25").style.display = "none";
document.getElementById("toDo25").style.display = "none";
document.getElementById("data26").style.display = "none";
document.getElementById("toDo26").style.display = "none";
document.getElementById("data27").style.display = "none";
document.getElementById("toDo27").style.display = "none";
document.getElementById("data28").style.display = "none";
document.getElementById("toDo28").style.display = "none";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput2H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "none";
document.getElementById("toDo23").style.display = "none";
document.getElementById("data24").style.display = "none";
document.getElementById("toDo24").style.display = "none";
document.getElementById("data25").style.display = "none";
document.getElementById("toDo25").style.display = "none";
document.getElementById("data26").style.display = "none";
document.getElementById("toDo26").style.display = "none";
document.getElementById("data27").style.display = "none";
document.getElementById("toDo27").style.display = "none";
document.getElementById("data28").style.display = "none";
document.getElementById("toDo28").style.display = "none";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput3H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "none";
document.getElementById("toDo24").style.display = "none";
document.getElementById("data25").style.display = "none";
document.getElementById("toDo25").style.display = "none";
document.getElementById("data26").style.display = "none";
document.getElementById("toDo26").style.display = "none";
document.getElementById("data27").style.display = "none";
document.getElementById("toDo27").style.display = "none";
document.getElementById("data28").style.display = "none";
document.getElementById("toDo28").style.display = "none";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput4H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "block";
document.getElementById("data25").style.display = "none";
document.getElementById("toDo25").style.display = "none";
document.getElementById("data26").style.display = "none";
document.getElementById("toDo26").style.display = "none";
document.getElementById("data27").style.display = "none";
document.getElementById("toDo27").style.display = "none";
document.getElementById("data28").style.display = "none";
document.getElementById("toDo28").style.display = "none";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput5H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "block";
document.getElementById("data25").style.display = "block";
document.getElementById("data26").style.display = "none";
document.getElementById("toDo26").style.display = "none";
document.getElementById("data27").style.display = "none";
document.getElementById("toDo27").style.display = "none";
document.getElementById("data28").style.display = "none";
document.getElementById("toDo28").style.display = "none";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput6H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "block";
document.getElementById("data25").style.display = "block";
document.getElementById("data26").style.display = "block";
document.getElementById("data27").style.display = "none";
document.getElementById("toDo27").style.display = "none";
document.getElementById("data28").style.display = "none";
document.getElementById("toDo28").style.display = "none";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput7H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "block";
document.getElementById("data25").style.display = "block";
document.getElementById("data26").style.display = "block";
document.getElementById("data27").style.display = "block";
document.getElementById("data28").style.display = "none";
document.getElementById("toDo28").style.display = "none";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput8H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "block";
document.getElementById("data25").style.display = "block";
document.getElementById("data26").style.display = "block";
document.getElementById("data27").style.display = "block";
document.getElementById("data28").style.display = "block";
document.getElementById("data29").style.display = "none";
document.getElementById("toDo29").style.display = "none";
document.getElementById("data30").style.display = "none";
}
function onlyShowInput9H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "block";
document.getElementById("data25").style.display = "block";
document.getElementById("data26").style.display = "block";
document.getElementById("data27").style.display = "block";
document.getElementById("data28").style.display = "block";
document.getElementById("data29").style.display = "block";
document.getElementById("data30").style.display = "none";
document.getElementById("toDo30").style.display = "none";
}
function onlyShowInput10H() {
document.getElementById("data21").style.display = "block";
document.getElementById("data22").style.display = "block";
document.getElementById("data23").style.display = "block";
document.getElementById("data24").style.display = "block";
document.getElementById("data25").style.display = "block";
document.getElementById("data26").style.display = "block";
document.getElementById("data27").style.display = "block";
document.getElementById("data28").style.display = "block";
document.getElementById("data29").style.display = "block";
document.getElementById("data30").style.display = "block";
}
/*START show save btns*/
function showSaveE() {
document.getElementById("saveE").style.display = "block";
}
function showSaveM() {
document.getElementById("saveM").style.display = "block";
}
function showSaveH() {
document.getElementById("saveH").style.display = "block";
}
/*END of show btns*/
/* START: function show input easy*/
function showInputE() {
var numEAI = document.getElementById('numEAI');
if (numEAI.value == 0) {
alert("If you don't have any, click I don't have any easy assignments today");
} else if (numEAI.value == 1) {
showSaveE();
onlyShowInput1();
} else if (numEAI.value == 2) {
showSaveE();
onlyShowInput2();
} else if (numEAI.value == 3) {
showSaveE();
onlyShowInput3();
} else if (numEAI.value == 4) {
showSaveE();
onlyShowInput4();
} else if (numEAI.value == 5) {
showSaveE();
onlyShowInput5();
} else if (numEAI.value == 6) {
showSaveE();
onlyShowInput6();
} else if (numEAI.value == 7) {
showSaveE();
onlyShowInput7();
} else if (numEAI.value == 8) {
showSaveE();
onlyShowInput8();
} else if (numEAI.value == 9) {
showSaveE();
onlyShowInput9();
} else if (numEAI.value == 10) {
showSaveE();
onlyShowInput10();
} else {
alert("Try doing between 1-10 easy assignments OR click I dont have any easy assignments today if you dont have any");
}
}
/* START: function show input medium*/
function showInputM() {
var numMAI = document.getElementById('numMAI');
if (numMAI.value == 0) {
alert("If you don't have any, click I don't have any medium assignments");
} else if (numMAI.value == 1) {
showSaveM();
onlyShowInput1M();
} else if (numMAI.value == 2) {
showSaveM();
onlyShowInput2M();
} else if (numMAI.value == 3) {
showSaveM();
onlyShowInput3M();
} else if (numMAI.value == 4) {
showSaveM();
onlyShowInput4M();
} else if (numMAI.value == 5) {
showSaveM();
onlyShowInput5M();
} else if (numMAI.value == 6) {
showSaveM();
onlyShowInput6M();
} else if (numMAI.value == 7) {
showSaveM();
onlyShowInput7M();
} else if (numMAI.value == 8) {
showSaveM();
onlyShowInput8M();
} else if (numMAI.value == 9) {
showSaveM();
onlyShowInput9M();
} else if (numMAI.value == 10) {
showSaveM();
onlyShowInput10M();
} else {
alert("Try doing 1-10 medium assuignments OR click I dont have any medium assignments today if you dont have any");
}
}
/* START: function show input hard*/
function showInputH() {
var numHAI = document.getElementById('numHAI');
if (numHAI.value == 0) {
alert("If you don't have any, click I don't have any hard assignents");
} else if (numHAI.value == 1) {
onlyShowInput1H();
showSaveH();
} else if (numHAI.value == 2) {
onlyShowInput2H();
showSaveH();
} else if (numHAI.value == 3) {
onlyShowInput3H();
showSaveH();
} else if (numHAI.value == 4) {
onlyShowInput4H();
showSaveH();
} else if (numHAI.value == 5) {
onlyShowInput5H();
showSaveH();
} else if (numHAI.value == 6) {
onlyShowInput6H();
showSaveH();
} else if (numHAI.value == 7) {
onlyShowInput7H();
showSaveH();
} else if (numHAI.value == 8) {
onlyShowInput8H();
showSaveH();
} else if (numHAI.value == 9) {
onlyShowInput9H();
showSaveH();
} else if (numHAI.value == 10) {
onlyShowInput10H();
showSaveH();
} else {
alert("Try doing between 1-10 hard assignments OR click I dont have any hard assignments today if you dont have any");
}
}
/* display functions in form */
function displayM() {
document.getElementById("easyAssignments").style.display = "none";
document.getElementById("mediumAssignments").style.display = "block";
}
function displayH() {
document.getElementById("mediumAssignments").style.display = "none";
document.getElementById("hardAssignments").style.display = "block";
}
function displayTDL() {
document.getElementById("hardAssignments").style.display = "none";
document.getElementById("toDoList").style.display = "block";
}
<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
<meta charset="utf-8">
<title>To Do List</title>
<!--JS Files-->
</head>
<body style="font-family: 'Roboto', sans-serif;">
<form id="ui">
<fieldset>
<!--Start of Form-->
<div id="hardAssignments">
<p>How many hard tasks do you have to do today?</p>
<input class="pink" min="0" max="10" type="number" id="numHAI" required>
<p></p>
<script src="ITHB.js"></script>
<button style="display:block" class="btn btn-primary" onclick="showInputHText(); showInputH();">Enter</button>
<p style="display:none;" id="inputHText">List your hard tasks here (then click save)</p>
<input class="red" style="display:none" id='data21' name='data21'>
<input id="saveH" value="submit" class="btn btn-primary" type="submit" onclick="displayTDL()" />
<p>or</p>
<button value="submit" type="submit" class="btn btn-secondary" onclick="dontShowInput1H();
displayTDL();">
I don't have any hard tasks today
</button>
</div>
</div>
<center>
<!--End of Form-->
<!--Start of To-do List-->
<div text-align="center" id=toDoList style="display:none">
<h1>To Do List:</h1>
<h3>Hard Tasks:</h3>
<p>All your hard tasks for the day</p>
<input type="checkbox" style="font-size: 30px;" id="toDo21" name="toDo21" value="toDo21" />
<label style="font-size: 30px;" class="strikethrough" for="toDo21"><output id='out21' for="data21"></output></label><br>
</fieldset>
</form>
</div>
<script src="ITHB.js"></script>
<script src="script.js"></script>
<!--End of To-do List-->
</center>
</body>
</html>

First error: You are missing name="btn" on line 26 of index.html
<button name="btn" class="btn btn-primary" onclick="showInputEText(); showInputE();">Enter</button>
Second error: You have two typos on line 50 and 51 of script.js, ou should be out.
var out15 = ui.out15;
Third error: You have are trying to get a lot of elements that dont exist in your html (data22 - data30).

Javascript: How can this code be reduced or improved?

This is some JS that I've written, how can this be reduced?
it swaps the text as in hides one div and displays the other.
var directorOne = document.getElementById('directorOne').addEventListener("click", changeText);
var directorOneText = document.getElementById('directorOneText');
function changeText() {
if (directorOneText.style.display === "block") {
directorOneText.style.display = "none";
directorTwoText.style.display = "none";
console.log("luke open");
} else {
directorOneText.style.display = "block";
directorTwoText.style.display = "none";
}
}
var directorTwo = document.getElementById('directorTwo').addEventListener("click", changeText2);
var directorTwoText = document.getElementById('directorTwoText');
function changeText2() {
if (directorTwoText.style.display === "block") {
directorTwoText.style.display = "none";
directorOneText.style.display = "none";
console.log("bruce open");
} else {
directorTwoText.style.display = "block";
directorOneText.style.display = "none";
}
}

Using a single function that is called with the elements as parameters
var directorOneText = document.getElementById('directorOneText');
var directorTwoText = document.getElementById('directorTwoText');
function changeText(t1, t2) {
t1.style.display = (t1.style.display === "block") ? "none" : "block";
t2.style.display = "none";
}
var directorOneClickEvent = document.getElementById('directorOne').addEventListener("click", function(){ changeText(directorOneText, directorTwoText)});
var directorTwoClickEvent = document.getElementById('directorTwo').addEventListener("click", function(){ changeText(directorTwoText, directorOneText)});
#directorOne {background:#333; padding: 20px;}
#directorTwo {background:#ddd; padding: 20px;}
<div id="directorOne">d1<textarea id="directorOneText"></textarea></div>
<div id="directorTwo">d2<textarea id="directorTwoText"></textarea></div>

Javascript Hide/Show multiple elements

my code isn't working:
JS:
function openform_1() {
var a = document.getElementById("2");
if (a.style.display === "inline") {
document.getElementById("form_1").style.display = ("inline");
document.getElementById("form_1_b").style.display = ("inline");
document.getElementById("2").style.display = ("none");
document.getElementById("3").style.display = ("none");
document.getElementById("4").style.display = ("none");
document.getElementById("5").style.display = ("none");
document.getElementById("6").style.display = ("none");
document.getElementById("7").style.display = ("none");
document.getElementById("8").style.display = ("none");
document.getElementById("9").style.display = ("none");
}
if (a.style.display === "none") {
document.getElementById("form_1").style.display = ("none");
document.getElementById("form_1_b").style.display = ("none");
document.getElementById("2").style.display = ("inline");
document.getElementById("3").style.display = ("inline");
document.getElementById("4").style.display = ("inline");
document.getElementById("5").style.display = ("inline");
document.getElementById("6").style.display = ("inline");
document.getElementById("7").style.display = ("inline");
document.getElementById("8").style.display = ("inline");
document.getElementById("9").style.display = ("inline");
}}
HTML:
<img src="img/edit.png" width="15" height="15" class="edit"id="1" onclick="openform_1()">
<img src="img/edit.png" width="15" height="15" class="edit" id="2" onclick="openform_2()">
...
CSS:
.edit {display: inline;}
When I'm clicking on the image with the id "1" nothing happens. What I want it to happen is that all elements with the id from 2-9 disappear and the elements with the id "form_1" and "form_1_b" appear.
Clicking "1" again should restore everything.
edit:
function openform_2() {
var a = document.getElementById("1");
if (a.style.display === "inline") {
document.getElementById("form_2").style.display = "inline";
document.getElementById("form_2_b").style.display = "inline";
document.getElementById("1").style.display = "none";
document.getElementById("3").style.display = "none";
document.getElementById("4").style.display = "none";
document.getElementById("5").style.display = "none";
document.getElementById("6").style.display = "none";
document.getElementById("7").style.display = "none";
document.getElementById("8").style.display = "none";
document.getElementById("9").style.display = "none";
}
if (a.style.display === "none") {
document.getElementById("form_2").style.display = "none";
document.getElementById("form_2_b").style.display = "none";
document.getElementById("1").style.display = "inline";
document.getElementById("3").style.display = "inline";
document.getElementById("4").style.display = "inline";
document.getElementById("5").style.display = "inline";
document.getElementById("6").style.display = "inline";
document.getElementById("7").style.display = "inline";
document.getElementById("8").style.display = "inline";
document.getElementById("9").style.display = "inline";
}}
This is how it looks like in the browser:
Clicked:
This is how it should look like when I click one time.

Use an else if on the second if statement.
If it isn't an else if then it would say does it equal inline? Then set it to none. Does it equal none? Yes it does because it just changed it to it, so change it back to inline.
Else if means it won't do it if the first if is true.

Consider replacing ('inline') with "inline".
Removes the quotes.
For example:
document.getElementById("3").style.display = "inline";
You made classic repetitive errors.

how to remove images during the setTimeout?

case FOCUS_AA:
if(keyCode == KEY_RIGHT){
focus = FOCUS_AB;
clearTimeout(a);
document.getElementById("background").style.display = "block";
document.getElementById("backLight").style.display = "block";
document.getElementById("treeBoard").style.display = "block";
document.getElementById("bImg").style.display = "block";
document.getElementById("aImg").style.display = "none";
document.getElementById("a0").style.display = "none";
document.getElementById('banana').play();
banana1();
function banana1(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b0").style.display = "block";
/*var a = setTimeout(apple2, 1000);*/
b = setTimeout(banana2, 1000);
}
function banana2(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b0").style.display = "none";
document.getElementById("b1").style.display = "block";
b = setTimeout(banana3, 1000);
}
function banana3(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b1").style.display = "none";
document.getElementById("b2").style.display = "block";
b = setTimeout(banana4, 1000);
}
function banana4(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b2").style.display = "none";
document.getElementById("b3").style.display = "block";
b = setTimeout(banana5, 1000);
}
function banana5(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b3").style.display = "none";
document.getElementById("b4").style.display = "block";
b = setTimeout(banana6, 1000);
}
function banana6(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b4").style.display = "none";
document.getElementById("b5").style.display = "block";
b = setTimeout(banana7, 1000);
}
function banana7(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b5").style.display = "none";
document.getElementById("b6").style.display = "block";
b = setTimeout(banana8, 1000);
}function banana8(){
document.getElementById("bImg").style.display = "block";
document.getElementById("b6").style.display = "none";
document.getElementById("b0").style.display = "block";
b = setTimeout(banana8, 1000);
}
}else if(keyCode == KEY_BACK){
focus == FOCUS_A
window.location.href = 'Shop.html';
}
break;
case FOCUS_AB:
if(keyCode == KEY_LEFT){
focus = FOCUS_AA;
clearTimeout(b);
document.getElementById("background").style.display = "block";
document.getElementById("backLight").style.display = "block";
document.getElementById("treeBoard").style.display = "block";
document.getElementById("a0").style.display = "block";
document.getElementById("aImg").style.display = "block";
document.getElementById("bImg").style.display = "none";
document.getElementById("b0").style.display = "none";
document.getElementById('apple').play();
apple0();
function apple0(){
document.getElementById("aImg").style.display = "block";
document.getElementById("a0").style.display = "block";
a = setTimeout(apple1, 1000);
}
function apple1(){
document.getElementById("aImg").style.display = "block";
document.getElementById("a0").style.display = "none";
document.getElementById("a1").style.display = "block";
a = setTimeout(apple2, 1000);
}
function apple2(){
document.getElementById("aImg").style.display = "block";
document.getElementById("a1").style.display = "none";
document.getElementById("a2").style.display = "block";
a = setTimeout(apple3, 1000);
}
function apple3(){
document.getElementById("aImg").style.display = "block";
document.getElementById("a2").style.display = "none";
document.getElementById("a3").style.display = "block";
a = setTimeout(apple4, 1000);
}
function apple4(){
document.getElementById("aImg").style.display = "block";
document.getElementById("a3").style.display = "none";
document.getElementById("a4").style.display = "block";
a = setTimeout(apple5, 1000);
}
function apple5(){
document.getElementById("aImg").style.display = "block";
document.getElementById("a4").style.display = "none";
document.getElementById("a5").style.display = "block";
a = setTimeout(apple6, 1000);
}
function apple6(){
document.getElementById("aImg").style.display = "block";
document.getElementById("a5").style.display = "none";
document.getElementById("a0").style.display = "block";
a = setTimeout(apple6, 1000);
}
}else if(keyCode == KEY_RIGHT){
focus = FOCUS_AC;
clearTimeout(b);
document.getElementById('b_').style.display ='none';
document.getElementById("background").style.display = "block";
document.getElementById("backLight").style.display = "block";
document.getElementById("treeBoard").style.display = "block";
document.getElementById("c0").style.display = "block";
document.getElementById("cImg").style.display = "block";
document.getElementById("bImg").style.display = "none";
document.getElementById("b0").style.display = "none";
document.getElementById('cake').play();
cake1();
function cake1(){
document.getElementById("cImg").style.display = "block";
document.getElementById("c0").style.display = "block";
c = setTimeout(cake2, 1000);
}
function cake2(){
document.getElementById("cImg").style.display = "block";
document.getElementById("c0").style.display = "none";
document.getElementById("c1").style.display = "block";
c = setTimeout(cake3, 1000);
}
function cake3(){
document.getElementById("cImg").style.display = "block";
document.getElementById("c1").style.display = "none";
document.getElementById("c2").style.display = "block";
c = setTimeout(cake4, 1000);
}
function cake4(){
document.getElementById("cImg").style.display = "block";
document.getElementById("c2").style.display = "none";
document.getElementById("c3").style.display = "block";
c = setTimeout(cake5, 1000);
}
function cake5(){
document.getElementById("cImg").style.display = "block";
document.getElementById("c3").style.display = "none";
document.getElementById("c4").style.display = "block";
c = setTimeout(cake6, 1000);
}
function cake6(){
document.getElementById("cImg").style.display = "block";
document.getElementById("c4").style.display = "none";
document.getElementById("c0").style.display = "block";
c = setTimeout(cake6, 1000);
}
} else if(keyCode == KEY_BACK){
focus == FOCUS_B
window.location.href = 'Shop.html';
}
break;
this shows using setTimeout to animate the images.
when i press "KEY_RIGHT" : the images stopped and shows next animated image.
but problem is images overlaps with stopped images and the next images.
how do i remove all the stopped or previous images(FOCUS_AA) when key pressed next step(FOCUS_AB)?

If you were to animate via jQuery, you could call .stop() on all animations and have the always action on animations would be to hide the photos. That way, even if you were in the middle of an animation, the animation would stop, go immediately to the end and the next animation would go.

Develop Reference

JavaScript is the programming language of the Web.

Avoid repeating myself - javascript

Related

How loop through HTML Elements

Cannot read property 'style' of null in three places

Javascript: How can this code be reduced or improved?

Javascript Hide/Show multiple elements

how to remove images during the setTimeout?

Categories

Resources