i'm very new to js, and it's my first code on it. i'm trying to make a game "rock, papper, scissors". please, look at my code, my funcrion playRound doesn't wor, i need it to return scores.
please, give me advises how to change my code, but i don't want you to solve all for me. thank you.
function computerPlay() {
let computerAction = Math.floor(Math.random() * choises.length);
let computerSelection = choises[computerAction];
return computerSelection;
}
function userPlay() {
let playerSelection = prompt(choises).toLowerCase();
return playerSelection;
}
let choises = ['rock', 'paper', 'scissors'];
let Score = new Map([
['userScores', 0],
['computerScores', 0]
]);
function playRound(playerSelection, computerSelection) {
if (playerSelection === choises[0] && computerSelection === choises[0]) ||
(playerSelection === choises[1] && computerSelection === choises[1]) ||
(playerSelection === choises[2] && computerSelection === choises[2]){
return Score = ['userScores' + 1, 'computerScores' + 1];
} else if (playerSelection === choises[0] && computerSelection !== choises[0]) ||
(playerSelection === choises[1] && computerSelection !== choises[1]) ||
(playerSelection === choises[2] && computerSelection !== choises[2])
return Score = ['userScores' + 1, 'computerScores'];
} else if (playerSelection !== choises[0] && computerSelection === choises[0]) ||
(playerSelection !== choises[1] && computerSelection === choises[1]) ||
(playerSelection !== choises[2] && computerSelection === choises[2])
{
return Score = ['userScores', 'computerScores' + 1];
}
}
Refer to this:
function computerPlay() {
let computerAction = Math.floor(Math.random() * choises.length);
let computerSelection = choises[computerAction];
return computerSelection;
}
function userPlay() {
let playerSelection = prompt(choises).toLowerCase();
return playerSelection;
}
let choises = ['rock', 'paper', 'scissors'];
let Score = {
user: 0,
computer: 0
}
function playRound(playerSelection, computerSelection) {
if (playerSelection === computerSelection){
Score.user = Score.user + 1;
Score.computer = Score.computer + 1;
} else if ((playerSelection === choises[0] && computerSelection === choises[2]) ||
(playerSelection === choises[1] && computerSelection === choises[0]) ||
(playerSelection === choises[2] && computerSelection === choises[1])) {
Score.user = Score.user + 1;
} else {
Score.computer = Score.computer + 1;
}
}
let computerChoice = computerPlay();
let userChoice = userPlay();
playRound(userChoice, computerChoice);
console.log('computer hand', computerChoice);
console.log('user hand', userChoice);
console.log(Score);
Related
The project is about making a rock paper scissors game using functions and loops etc.
the code below is how the project looks
the first function is to get the randomized computer choice
the second function is to get the user or players choice
the third function is to play the game and check if the player won or the computer won
the final function is to create a for loop to run the third function a certain number of times to see who is the winner of the game
Been working on it since and have no idea why it doesn't work
```
function getComputerChoice() {
let values = ["rock", "paper", "scissors"];
return values[Math.floor(Math.random() * values.length)];
}
function getPlayerChoice() {
let getChoice = "rock";
let value = getChoice.trim();
let lowCase = value.toLowerCase();
let capitalize = lowCase.charAt(0).toUpperCase + lowCase.slice(1);
while (!["Rock", "Paper", "Scissors"].includes(capitalize)) {
value = getChoice.trim();
lowCase = value.toLowerCase();
capitalize = lowCase.charAt(0).toUpperCase + lowCase.slice(1);
}
return capitalize;
}
function playRound(playerSelection, computerSelection) {
let games = "";
if (
(playerSelection == "rock" && computerSelection == "paper") ||
(playerSelection == "paper" && computerSelection == "scissors") ||
(playerSelection == "scissors" && computerSelection == "rock")
) {
return (games =
"player loses!! " + computerSelection + " beats " + playerSelection);
} else if (
(playerSelection == "paper" && computerSelection == "rock") ||
(playerSelection == "scissors" && computerSelection == "paper") ||
(playerSelection == "rock" && computerSelection == "scissors")
) {
return (games =
"player Wins!! " + playerSelection + " beats " + computerSelection);
} else if (playerSelection == computerSelection) {
return (games =
"it a tie noice " + playerSelection + " v " + computerSelection);
} else {
return (games = "euphoria");
}
}
function game() {
let playerScores = 0;
let computerScores = 0;
let computerSelection = "";
let playerSelection = "";
computerSelection = getComputerChoice();
playerSelection = getPlayerChoice();
for (let i = 0; i < 5; i++) {
if (
playRound(
"player loses!! " + computerSelection + " beats " + playerSelection
)
) {
computerScores += 1;
console.log(
"you lost this round!! boo hoo!! scores are " +
computerScores +
" v " +
playerScores
);
} else if (
playRound(
"player Wins!! " + playerSelection + " beats " + computerSelection
)
) {
playerScores += 1;
console.log(
"you Won this round!! hurray!! scores are " +
computerScores +
" v " +
playerScores
);
}
}
if (playerScores > computerScores) {
console.log("congratulations you won this round");
} else if (playerScores < computerScores) {
console.log("im sorry you lost this round");
} else {
console.log("there is a problem");
}
}
game();
```
It doesn't seem that playRound() is returning anything:
function playRound(playerSelection, computerSelection) {
let games = '';
if (
(playerSelection == "rock" && computerSelection == "paper") ||
(playerSelection == "paper" && computerSelection == "scissors") ||
(playerSelection == "scissors" && computerSelection == "rock")
) {
games = "player loses!! " + computerSelection + " beats " + playerSelection;
// ADD RETURN HERE
} else if (
(playerSelection == "paper" && computerSelection == "rock") ||
(playerSelection == "scissors" && computerSelection == "paper") ||
(playerSelection == "rock" && computerSelection == "scissors")
) {
games = "player Wins!! " + playerSelection + " beats " + computerSelection;
// ADD RETURN HERE
} else if (playerSelection == computerSelection) {
games = "it a tie noice " + playerSelection + " v " + computerSelection;
// ADD RETURN HERE
} else {
games = "euphoria";
// ADD RETURN HERE
}
}
Explanation
In your game() function definition you are checking if(playRound()). playRound is not returning anything so this is interpreted as a void function, hence, the if will always evaluate to false.
I've put playerScore and computerScore variables in global scope. When user wins or loses these values increment by one number. They do work well. But in my HTML page they do not change dynamically.
Why my playerScore and computerScore values do not change in my HTML page, when I console.log them separately in console they are changed, but not in html page. I've tried to put them in function but it didn't work as expected.
// Selecting all the items with tag button
const buttons = document.querySelectorAll('button');
// Returns random item and assignes it to computerSelection variable
function computerPlay() {
const rps = ['rock', 'paper', 'scissors'];
let numberItem = Math.floor(Math.random() * rps.length);
computerSelection = rps[numberItem];
if (computerSelection === 'rock') {
console.log('computer selections is rock');
return computerSelection;
}
else if (computerSelection === 'paper' ) {
console.log('It is a paper!');
return computerSelection;
}
console.log('it is scissors');
return computerSelection;
}
// Plays game only five rounds;
let computerScore = 0;
let playerScore = 0;
function playRound(playerSelection, computerSelection) {
if(playerScore < 5 && computerScore < 5 ) {
if(((playerSelection == 'rock') && (computerSelection == 'paper')) || ((playerSelection == 'paper') && (computerSelection == 'scissors')) ||
((playerSelection == 'scissors') && (computerSelection == 'rock') )) {
console.log(`${computerSelection} beats ${playerSelection} the ROBOT WINS!`);
playerScore++;
return console.log(playerScore);
}
else if (((playerSelection == 'rock') && (computerSelection == 'scissors')) || ((playerSelection == 'paper') && (computerSelection == 'rock')) ||
((playerSelection == 'scissors') && (computerSelection == 'paper'))) {
console.log(` ${playerSelection} beats ${computerSelection} the PLAYER WINS!`);
computerScore++;
return console.log(computerScore);
}
return console.log('It is a DRAW');;
}
return console.log("GAME OVER!!!");
}
// returns value of clicked button and plays round
function fetchButtonValue(e) {
let itemClicked = e.target.dataset.item;
console.log(` THIS WAS CLICKED ${itemClicked}`);
return playRound(itemClicked, computerPlay());
}
// uses fetchButtonValue
buttons.forEach(function(button) {
button.addEventListener('click', fetchButtonValue);
});
// implement the vlaues to HTML but they doesn't change but the value changes when tracking them in console of browser.
let score= `
<p class = 'playerPoints'>Player: ${playerScore}</p>
<p class = 'computerPoints'>Computer: ${computerScore}</p>
`;
const divScore = document.querySelector('.score');
divScore.insertAdjacentHTML('beforebegin', scoreHTML);
Can anyone tell me why my code doesn't work properly? I'm trying to make game ROCK, PAPER, SCISSORS on plain Java Script. For some reason it doesn't work as I expect.
const computerAanswer = ["rock", "paper", "scissors"];
function computerPlay() {
let answer = computerAanswer[Math.floor(Math.random() * computerAanswer.length)];
return answer;
}
console.log('computer choice is: ' + computerPlay().toUpperCase());
function playRound (playerSelection, computerSelection) {
playerSelection = playerSelection.toLowerCase()
if (playerSelection == "rock" && computerSelection == "scissors") {
return "Congrats,you are winner!";
} else if (playerSelection == "paper" && computerSelection == "rock") {
return "Congrats,you are winner!";
} else if (playerSelection == "scissors" && computerSelection == "paper") {
return "Congrats,you are winner!";
} else if (playerSelection == "rock" && computerSelection == "rock") {
return "Draw!";
} else if (playerSelection == "paper" && computerSelection == "paper") {
return "Draw!";
} else if (playerSelection == "scissors" && computerSelection == "scissors") {
return "Draw!";
} else {
return "You lose. Maybe next time...";
}
}
let playerSelection = prompt("Make your choose: Rock, Paper or Scissors?");
let computerSelection = computerPlay();
console.log(playRound(playerSelection, computerSelection));
console.log('player choice is: ' + playerSelection.toUpperCase());
I guess that's just your first console.log :
console.log('computer choice is: ' + computerPlay().toUpperCase());
It plays a round for computer, then you play another one against prompted user.
Do that instead :
function computerPlay() {
let answer = computerAanswer[Math.floor(Math.random() * computerAanswer.length)];
console.log('computer choice is: ' + answer.toUpperCase());
return answer;
}
When I nested
console.log('computer choice is: ' + answer.toUpperCase());
into computerPlay function it works.
const computerAanswer = ["rock", "paper", "scissors"];
function computerPlay() {
let answer = computerAanswer[Math.floor(Math.random() * computerAanswer.length)];
console.log('computer choice is: ' + answer.toUpperCase());
return answer;
}
function playRound (playerSelection, computerSelection) {
playerSelection = playerSelection.toLowerCase()
if (playerSelection == "rock" && computerSelection == "scissors") {
return "Congrats,you are winner!";
} else if (playerSelection == "paper" && computerSelection == "rock") {
return "Congrats,you are winner!";
} else if (playerSelection == "scissors" && computerSelection == "paper") {
return "Congrats,you are winner!";
} else if (playerSelection == "rock" && computerSelection == "rock") {
return "Draw!";
} else if (playerSelection == "paper" && computerSelection == "paper") {
return "Draw!";
} else if (playerSelection == "scissors" && computerSelection == "scissors") {
return "Draw!";
} else {
return "You lose. Maybe next time...";
}
}
let playerSelection = prompt("Make your choose: Rock, Paper or Scissors?");
let computerSelection = computerPlay();
console.log(playRound(playerSelection, computerSelection));
console.log('player choice is: ' + playerSelection.toUpperCase());
I am building my first rock paper scissors game. I have not formally done loops as yet but I am trying to apply a for loop to the playRound function so it plays five times. Sadly I am not certain where to apply it. I have tried a few ways but keep getting errors. Anyone able to take a look and provide an option. code is below.
function computerPlay() {
const number = Math.floor(Math.random() * 1000);
if (number % 3 === 0) {
return "rock";
}
if (number % 3 === 1) {
return "paper";
} else {
return "scissors";
}
}
function playRound(playerSelection, computerSelection) {
playerSelection = "rock";
computerSelection = computerPlay();
if (
(playerSelection == "rock" && computerSelection == "scissors") ||
(playerSelection == "scissors" && computerSelection == "paper") ||
(playerSelection == "paper" && computerSelection == "rock")
) {
return "Player Wins!";
} else if (
(playerSelection == "rock" && computerSelection == "paper") ||
(playerSelection == "paper" && computerSelection == "scissors") ||
(playerSelection == "scissors" && computerSelection == "rock")
) {
return "Computer Wins!";
} else {
return "Tie";
}
}
playerSelection = "rock";
computerSelection = computerPlay();
console.log(playRound(playerSelection, computerSelection));
If I understood correctly what you want, you can do a while loop with a counter, also I improved a bit your code, making strict equality (from == to ===), and removed redundant code
let counter = 1;
function computerPlay() {
const number = Math.floor(Math.random() * 1000);
if (number % 3 === 0) {
return "rock";
} else if (number % 3 === 1) {
return "paper";
} else {
return "scissors";
}
}
function playRound(playerSelection, computerSelection) {
counter++;
if (
(playerSelection === "rock" && computerSelection === "scissors") ||
(playerSelection === "scissors" && computerSelection === "paper") ||
(playerSelection === "paper" && computerSelection === "rock")
) {
return "Player Wins!";
} else if (
(playerSelection === "rock" && computerSelection == "paper") ||
(playerSelection === "paper" && computerSelection === "scissors") ||
(playerSelection === "scissors" && computerSelection === "rock")
) {
return "Computer Wins!";
} else {
return "Tie";
}
}
playerSelection = "rock";
while (counter < 6) {
console.log(playRound(playerSelection, computerPlay()));
}
Hope this example gives some hint on how to do good programming
// rock = 0
// paper = 1
// scissor = 2
const valueMap = {
0: 'rock',
1: 'paper',
2: 'scissor'
}
function pick() {
return Math.floor(Math.random() * 3)
}
function decide(p1, p2) {
const pool = [p1, p2]
const sortedPool = pool.sort((a, b) => b.value - a.value)
const diff = sortedPool[0].value - sortedPool[1].value
if (diff === 2) {
return sortedPool[1].name
} else if (diff === 0) {
return 'draw'
} else {
return pool.find(v => v.value === sortedPool[0].value).name
}
}
function play(times, cb) {
let n = 1
while (n <= times) {
cb(n)
n++
}
}
play(5, function(n) {
const player1 = {
name: 'Player',
value: pick()
}
const player2 = {
name: 'Computer',
value: pick()
}
const result = decide(player1, player2)
console.log(
`Game ${n}`,
`${player1.name} ${valueMap[player1.value]}`,
` vs `,
`${player2.name} ${valueMap[player2.value]}`,
`>>> Winner ${result}
`
)
})
Add loop for last 3 line
for (i=0; i<5; i++){
playerSelection = "rock";
computerSelection = computerPlay();
console.log(playRound(playerSelection, computerSelection));
}
Edit: Please note that you have redundant call function computerPlay() inside playRound function since computer selection is passed in second argument
How can I loop my game of rock, paper, scissors and have it keep score with a win condition?
I have tried to create a "game" function that loops the rounds of RPS until the player or computer reaches a score of 5. However, I can't get the scores to stick, nor does the game loop.
playerSelection = prompt( ' Enter Rock, Paper, or Scissors');
let winner = 0;
let humanScore = 0;
let computerScore = 0;
function computerPlay() {
let number = Math.floor(Math.random() * (3 + 1));
if(number == 1)
return 'Rock';
else if(number == 2)
return 'Paper';
else return 'Scissors';
}
let computerSelection = computerPlay();
playerSelection = playerSelection.toUpperCase();
computerSelection = computerSelection.toUpperCase();
function game() {
while( humanScore <= 5 || computerScore <= 5) {
playRound();
}
}
function playRound(playerSelection, computerSelection) {
if( playerSelection === 'ROCK' && computerSelection === 'SCISSORS') {
humanScore +=1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if( playerSelection === 'ROCK' && computerSelection === 'PAPER') {
computerScore +=2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else if( playerSelection === 'ROCK' && computerSelection === 'ROCK') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if( playerSelection === 'PAPER' && computerSelection === 'ROCK') {
humanScore +=1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if( playerSelection === 'PAPER' && computerSelection === 'PAPER') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if( playerSelection === 'PAPER' && computerSelection === 'SCISSORS') {
computerScore +=2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else if( playerSelection === 'SCISSORS' && computerSelection === 'SCISSORS') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if( playerSelection === 'SCISSORS' && computerSelection === 'PAPER') {
humanScore += 1;
return playerSelection + ' wins vs ' +computerSelection + '. Congratulations!';
} else if( playerSelection === 'SCISSORS' && computerSelection === 'ROCK') {
computerScore +=2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else return 'Enter a valid move! Refresh the damn page!';
win_condition();
}
function win_condition() {
if( humanScore === 5 ) {
return 'Player Wins!';
}
if( computerScore === 5 ) {
return 'Computer wins!';
}
}
The program executes through one time and works, but doesn't repeat like I expect it to.
There are few issues in your code as highlighted in comment section:
Functions win_condition and game are never called.
Functions win_condition and playGround returns processed value but are accepted back.
if( humanScore === 5 ) or if( computerScore === 5 ) are always false. Condition to process is humanScore <= 5 || computerScore <= 5
if(humanScore <= 5 || computerScore <= 5) This will fail even if a player has more than 5 score.
let winner = 0;
let humanScore = 0;
let computerScore = 0;
function initializeGame() {
let playerSelection = prompt(' Enter Rock, Paper, or Scissors');
let computerSelection = computerPlay();
let msg = playRound(playerSelection, computerSelection);
console.log(msg);
if (humanScore <= 5 && computerScore <= 5) {
console.log('Current score: Human: ', humanScore, ' Computer: ', computerScore)
setTimeout(initializeGame, 0);
} else {
console.log(win_condition());
}
}
function computerPlay() {
let number = Math.floor(Math.random() * (3 + 1));
if (number == 1)
return 'Rock';
else if (number == 2)
return 'Paper';
else return 'Scissors';
}
function playRound(playerSelection, computerSelection) {
playerSelection = playerSelection.toUpperCase();
computerSelection = computerSelection.toUpperCase();
if (playerSelection === 'ROCK' && computerSelection === 'SCISSORS') {
humanScore += 1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if (playerSelection === 'ROCK' && computerSelection === 'PAPER') {
computerScore += 2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else if (playerSelection === 'ROCK' && computerSelection === 'ROCK') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if (playerSelection === 'PAPER' && computerSelection === 'ROCK') {
humanScore += 1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if (playerSelection === 'PAPER' && computerSelection === 'PAPER') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if (playerSelection === 'PAPER' && computerSelection === 'SCISSORS') {
computerScore += 2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else if (playerSelection === 'SCISSORS' && computerSelection === 'SCISSORS') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if (playerSelection === 'SCISSORS' && computerSelection === 'PAPER') {
humanScore += 1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if (playerSelection === 'SCISSORS' && computerSelection === 'ROCK') {
computerScore += 2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else return 'Enter a valid move! Refresh the damn page!';
}
function win_condition() {
if (humanScore > 5) {
return 'Player Wins!';
}
if (computerScore > 5) {
return 'Computer wins!';
}
}
initializeGame();
I tried fixing your code as below and it works fine now.
Game method is called initially.
Game rounds are controlled / iterated through game method.
Condition for next round is altered to while( humanScore <= 5 && computerScore <= 5) {
Alerts are added to show messages after each round and final winner.
let winner = 0;
let humanScore = 0;
let computerScore = 0;
function computerPlay() {
let number = Math.floor(Math.random() * (3 + 1));
if (number == 1)
return 'Rock';
else if (number == 2)
return 'Paper';
else return 'Scissors';
}
game();
function game() {
while (humanScore <= 5 && computerScore <= 5) {
let playerSelection = prompt(' Enter Rock, Paper, or Scissors');
let computerSelection = computerPlay();
playerSelection = playerSelection.toUpperCase();
computerSelection = computerSelection.toUpperCase();
alert(playRound(playerSelection, computerSelection));
}
alert(win_condition());
}
function playRound(playerSelection, computerSelection) {
if (playerSelection == 'ROCK' && computerSelection == 'SCISSORS') {
humanScore += 1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if (playerSelection == 'ROCK' && computerSelection == 'PAPER') {
computerScore += 2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else if (playerSelection == 'ROCK' && computerSelection == 'ROCK') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if (playerSelection == 'PAPER' && computerSelection == 'ROCK') {
humanScore += 1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if (playerSelection == 'PAPER' && computerSelection == 'PAPER') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if (playerSelection == 'PAPER' && computerSelection == 'SCISSORS') {
computerScore += 2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else if (playerSelection == 'SCISSORS' && computerSelection == 'SCISSORS') {
return playerSelection + ' ties with ' + computerSelection + '. Try again!';
} else if (playerSelection == 'SCISSORS' && computerSelection == 'PAPER') {
humanScore += 1;
return playerSelection + ' wins vs ' + computerSelection + '. Congratulations!';
} else if (playerSelection == 'SCISSORS' && computerSelection == 'ROCK') {
computerScore += 2;
return playerSelection + ' loses vs ' + computerSelection + '. Try again!';
} else return 'Enter a valid move! Refresh the damn page!';
}
function win_condition() {
if (humanScore == 5) {
return 'Player Wins!';
}
if (computerScore == 5) {
return 'Computer wins!';
}
}