Develop Reference

Why do I get ReferenceError: insertId is not defined on my 4th MySQL Query in NodeJS?

Why am I able to get the insertId from the first MySQL query but not further on in the code on the fourth query? The query is somewhat complex, but I don't know why something which works the first time doesn't work later on in the code;
var mysql = require("mysql");
var express = require("express");
var connection = require("../database")
var createAudiopost = function(req, res, next){
var title = req.body.title;
var userid = req.body.userid;
var opid = req.body.opid;
var tag1 = req.body.tag1;
connection.beginTransaction(function(err) {
if (err) { throw err; }
connection.query('INSERT INTO ?? (title,userid,opid) VALUES (?, ?, ? )', ['audioposts',title,userid,opid], function(err, result) {
if (err) {
connection.rollback(function() {
throw err;
});
}
var audioname = userid + '-' + result.insertId + '.m4a';
var newid = result.insertId;
console.log("newid: " , newid );
connection.query('UPDATE ?? SET audioname=? WHERE audioid = ?', ['audioposts',audioname,newid], function (error, result, fields) {
if (err) {
connection.rollback(function() {
throw err;
});
}
if (tag1) {
connection.query('SELECT tagid FROM tags WHERE tagname = ?', [tag1], function (error, result, fields) {
if (err) {
connection.rollback(function() {
throw err;
});
}
if (result < 1) {
connection.query('INSERT INTO tags SET tagname = ?', [tag1], function (error, result, fields) {
if (err) {
connection.rollback(function() {
throw err;
});
}
console.log("lets see this wierd error", result);
const tagInsertId = result.insertId;
connection.query("INSERT INTO entitytag SET audioid = ?, tagid = ?, userid = ?", [insertId, tagInsertId, userId], function (error, result, fields) {
if (err) {
connection.rollback(function() {
throw err;
});
}
connection.commit(function(err) {
if (err) {
connection.rollback(function() {
throw err;
});
}
console.log('success!');
newid = result.insertId;
res.json({
"title" : title,
"userid" : userid,
"opid" : opid,
"insertid": newid
}); //resjson success
}); //commit
}); // insert entitytags
}); // insert tags
} // if row
else {
const tagid1 = result.tagid;
connection.query("INSERT INTO entitytag SET audioid = ?, tagid = ?, userid = ?", [insertId, tagid1, userId], function (error, result, fields) {
if (err) {
connection.rollback(function() {
throw err;
}); //err
} //err
connection.commit(function(err) {
if (err) {
connection.rollback(function() {
throw err;
});
}
console.log('success!');
res.json({
"title" : title,
"userid" : userid,
"opid" : opid,
"insertid": newid
}); //resjson success
}); //commit
}) // insert entitytag2
}
}); //select tagid
}//tag1
}); //update
}); //insert
}); //begin transaction
} //createaudiopost
module.exports = createAudiopost;
The code gets as far as;
sql: "INSERT INTO tags SET tagname = 'dogmatism'"
But then error I get straight afterwards is;
Parser.js:437
throw err; // Rethrow non-MySQL errors
^
ReferenceError: insertId is not defined

insertId is not defined but used in the following queries:
connection.query("INSERT INTO entitytag SET audioid = ?, tagid = ?, userid = ?", [insertId, tagid1, userId], function (error, result, fields)
Looks like you meant to use newid instead as per the usage in the query:
connection.query('UPDATE ?? SET audioname=? WHERE audioid = ?', ['audioposts',audioname,newid], function (error, result, fields)
Replace the same here and it should work.
connection.query("INSERT INTO entitytag SET audioid = ?, tagid = ?, userid = ?", [newid, tagid1, userId], function (error, result, fields)
If not create a variable called insertId and initialise it before using it.

UnhandledPromiseRejectionWarning: Error: Cannot enqueue Handshake after already enqueuing a Handshake

I am trying to create a node.js server that would handle a POST request that would have data into two different MySQL tables.
Here the code behind my node.js server.
let mysql = require("mysql");
const http = require('http');
http.createServer(async function(req, res) {
let con = mysql.createConnection({
host: "...",
user: "...",
password: "...",
database: "..."
});
res.writeHead(200, {
"Content-Type": "application/json",
"Access-Control-Allow-Origin": "*"
});
if (req.method == 'POST') {
let body = '';
req.on('data', function(data) {
body += data.toString();
if (body.length > 10000000) {
http.request.connection.destroy();
}
});
req.on('end', () => {
if (body) {
let item = JSON.parse(body);
addQuestion(con, item.title).then(function(result){
con.end();
addOptions(con, result.insertId, item.options).then(function(data){
con.end();
res.end(JSON.stringify({
message: "Saved!"
}));
});
});
}
});
return;
}
res.end(JSON.stringify({
message: "OK!"
}));
}).listen(80);
function addQuestion(con, title) {
return new Promise((resolve, reject) => {
con.connect(function(err) {
if (err) return reject(err);
let sql = "INSERT INTO _questions SET ?";
con.query(sql, {title: title}, function(err, result, fields) {
if (err) return reject(err);
return resolve(result);
});
});
});
}
function addOptions(con, questionId, options) {
return new Promise((resolve, reject) => {
con.connect(function(err) {
if (err) return reject(err);
let values = [];
for(let x = 0 ; x < options.length; x++){
let option = options[x];
values.push({
title: option.title,
is_correct: option.isCorrect,
question_id: questionId
});
}
let optionsSql = "INSERT INTO _options (title, is_correct, question_id) VALUES ?";
con.query(questionSql, values, function(err, requestData) {
if (err) return reject(err);
return resolve(result);
});
});
});
}
I am getting the following error
UnhandledPromiseRejectionWarning: Error: Cannot enqueue Handshake
after already enqueuing a Handshake.
How can I solve this issue?

**If you using the node-MySQL module, just remove the .connect and .end. Just solved the problem myself.
**

Mongodb return old collection

router.post('/orders/finish', function(req, res, next) {
var order_id = req.body.order_id;
var user_id = req.body.user_id;
var table_id = '';
var result = [];
mongo.connect(url, function(err, db) {
assert.equal(null, err);
db.collection('tables').update({id: table_id, status: true}, {$set: {status: false}}, function(err, result) {
assert.equal(null, err);
});
var cursorTables = db.collection('tables').find({status: false});
cursorTables.forEach(function(doc, err) {
assert.equal(null, err);
result.push(doc);
}, function() {
db.close();
res.send(JSON.stringify(result));
});
});
I'm updating table collection and try to get them, but I get old collection without updating. However in the next request its changed.

When you make your .find() call, your collection isn't done updating yet.
You can choose to call .find() in the callback of your .update() call, or you could also use promises or async/await depending on your version.
Another solution would be to use findAndModify with the new option:
Optional. When true, returns the modified document rather than the original. The findAndModify() method ignores the new option for remove operations. The default is false.

You should wait for the update to complete before calling find
db.collection('tables').update({id: table_id, status: true}, {$set: {status: false}}, function(err, result) {
assert.equal(null, err);
var cursorTables = db.collection('tables').find({status: false});
cursorTables.forEach(function(doc, err) {
assert.equal(null, err);
resultTables.push(doc);
}, function() {
db.close();
});
});

I recommend you use Async
router.post('/', function(req, res) {
var order_id = req.body.order_id;
var user_id = req.body.user_id;
var table_id = '';
mongo.connect(url, table_id, function(err, db) {
myFuntion(db, table_id, function(result) {
res.send(JSON.stringify(result)); // it should be what you need
})
})
});
function myFuntion(db, table_id, callback) {
var result = [];
async.waterfall([
function(callback) {
db.collection('tables').update({id: table_id, status: true}, {$set: {status: false}}, function(err, result) {
assert.equal(null, err);
callback(null);
});
}, function(callback) {
db.collection('tables').find({status: false}, function(err, docs) {
docs.forEach(function(doc) {
result.push(doc);
})
callback(null, result);
});
}
], function(err, result) {
callback(result);
})
}

NodeJs check username and password return null

I'm trying to check the entered username and password stored in a database.
My solution is not correct and I think there might be something better than my code.
Here it is thus far:
function login (username, password, callback) {
var query = "SELECT * FROM users WHERE username = ?";
connection.query(query, [username], function (err, results) {
if (err) return callback(err);
if (results.length === 0) return callback();
var user = results[0];
if (!bcrypt.compareSync(password, user.password)) {
return callback();
}
callback(null, {
id: user.id.toString(),
});
});
}
app.get('/salam', function (req, res) {
var username = 'mahdi';
var originalPassword = 'a';
login(username , originalPassword,function (callback) {
console.log(callback);
});
});
In my code, console.log(callback); returns null, but usernames and passwords are correct. How can I fix this?

In your success callback function, you are having 2 arguments but in error callback, only one argument.
In error and success case, value of first parameter will always be null and in if (!bcrypt.compareSync(password, user.password)) { case, value of first argument will be undefined as there is no value being passed as argument.
Suggestion: Use first argument as Boolean(false or true) and based on the value, handle the callback.
function login(username, password, callback) {
var query = "SELECT * FROM users WHERE username = ?";
connection.query(query, [username], function(err, results) {
if (err) return callback(false);
if (results.length === 0) return callback();
var user = results[0];
if (!bcrypt.compareSync(password, user.password)) {
return callback(false);
}
callback(true, {
id: user.id.toString(),
});
});
}
app.get('/salam', function(req, res) {
var username = 'mahdi';
var originalPassword = 'a';
login(username, originalPassword, function(success, value) {
if (success) {
console.log(value);
}
});
});

It should be, because you didn't pass anything in callback. Change like this :
function login (username, password, callback) {
var query = "SELECT * FROM users WHERE username = ?";
connection.query(query, [username], function (err, results) {
if (err) return callback(err);
if (results.length === 0) return callback(null, false);
var user = results[0];
if (!bcrypt.compareSync(password, user.password)) {
return callback(null, false);
}
callback(null, true, {
id: user.id.toString(),
});
});
}
app.get('/check', function (req, res) {
var username = 'mahdi';
var originalPassword = 'a';
login(username , originalPassword,function (err, result, id) {
console.log(err);
console.log(result);
console.log(id);
});
});
result is for finding out true|false of action. And id means when result is true
Also err for callback is needed to error handling

Express JS res.redirect is undefined

I follow this tutorial on how to use passport-facebook in MEAN stack, I got this error when I try to use res.redirect('/signup') I always get this error: ReferenceError: res is not defined
it seems like I didn't pass res as a parameter in my function. I try to add it at second / last parameters. but nothing works. What do I miss???
Here is my code:
exports.saveOAuthUserProfile = function(req, profile, done){
User.findOne({
provider: profile.provider,
providerId: profile.providerId,
},
function(err, user) {
if (err) {
return done(err);
}
else
{
if (!user) {
// console.log(profile.email.value);
var possibleUsername = profile.username || ((profile.email) ? profile.email.value.split('#')[0] : '');
User.findUniqueUsername(possibleUsername, null, function(availableUsername){
profile.username = availableUsername;
user = new User(profile);
user.save(function(err){
if (err) {
var message = getErrorMessage(err);
// var message = _this.getErrorMessage(err);
req.flash('error', message);
return res.redirect('/register');
}
return done(err, user);
});
});
}
else
{
return done(err, user);
}
}
});
};