I am getting this JS error: ReferenceError: event is not defined when I try to pass the event object to click binding when I use Firefox 23. Everything works fine under Chrome
Here the code:
<!-- ko foreach: entries -->
<tr data-bind="click: function(){ $parent.expandRow($data, event) }">
...
</tr>
<!-- /ko -->
vm.entries.expandRow = function(entry, event){
...
}
Here the solution from github.com/knockout/knockout/issues/752
<!-- ko foreach: entries -->
<tr data-bind="click: function(data, event){ $parent.expandRow($data, event) }">
...
</tr>
<!-- /ko -->
Under Firefox event is not defined on the window object, instead it needs to be passed to the function.
I know that this is a pretty old question, but still if someone is looking for the answer then I achieved it in the following way:
<div id="this-element" data-bind="click : function(){ $root.clicked(event)}">
</div>
Following code (clicked function) is written in the ViewModel for the page:
this.clicked= function (event) {
console.log(event.currentTarget.id);
}
Knockout 3.4.2
jQuery 3.2.1
Related
I have a javascript object graph, an HTML form, and knockout bindings connecting the two. The form is complex, and sometimes the form needs to add some computed observables to some sub-object in our object graph, and I want to do that locally in the the HTML element that has the data-bind which relies on this, I don't want such knowledge somewhere in some global script.
<div class="widget" data-bind="foreach: subThing">
<script type="text/javascript">
$data._scratchpad = ko.computedObservable( ... );
</script>
...
<input data-bind="value: _scratchpad"/>
...
</div>
Now in the context of this script, the binding context is of course not yet set up, so the $data property is not yet available.
But is there some event that I might put on the element or something so I can catch when the bindings are first initialized so I can add the necessary things before the actual data-bind expressions want to refer to them?
I came up with a solution which is just a little ugly, but actually practically correct. Instead of this script element above, I just use a virtual element that contains nothing and whose only point is to get an if: condition evaluated, where then we put the statements into the body of a function that gets evaluated:
<div class="widget" data-bind="foreach: subThing">
<!-- ko if: (function() { if(!$data._scratchpad) {
$data._scratchpad = ko.computedObservable( ... );
}})() --> <!-- /ko -->
...
<input data-bind="value: _scratchpad"/>
...
</div>
The nice thing is that required no modification of the source code. And while it is just a little ugly with the boiler-plate code:
<!-- ko if: (function() { if(!...) {
...
}})() --> <!-- /ko -->
I could potentially use a custom binding's preprocessor to wrap this function around and say instead simply:
<!-- ko setup:
...
--> <!-- /ko -->
this is almost neat, but really not so much better that it's worth it.
It's kind-a handy that this virtual element definition is already in a comment, so there won't be any worries with the javascript code using special characters.
I'm trying to create a simple component in Knockout (3.3.0):
ko.components.register('test', {
viewModel: function() {
this.test = 'hello'
},
template:
`<span data-bind='if: 1, text: test'></span>`
});
ko.applyBindings();
See fiddle.
Now when I instantiate a <test></test> somewhere else, I get an error:
Multiple bindings (if and text) are trying to control descendant bindings of the same element. You cannot use these bindings together on the same element.
Is this really not possible? This would be like the most basic functionality to incorporate if you ask me. I know I could use <!-- ko text --> but what about setting other attributes like src and using if at the same time?
OK I found the (or at least, one possible) solution: Use <!-- ko if --><!-- /ko -->. This way, the template can be written like
<!-- ko if: 1-->
<span data-bind='text: test'></span>
<!-- /ko -->
I still don't think it's perfect, in Vue I would just do <span v-if='1'>{{text}}</span> bam done, but I guess not everything in this world can be as awesome as Vue...
I need to get a value from the ViewModel using a value from an object located in a loop in the view/page.
<!-- ko foreach: ExtendedItems() -->
<tr>
<!-- ko foreach: PriceGroups() -->
<!-- ko if: DeductibleAmount() === $root.FindDeductibleValue($parent.Provider()) -->
<td> --Content-- </td>
<!-- /ko -->
<!-- /ko -->
</tr>
<!-- /ko -->
I have a function in the ViewModel that finds the correct value:
self.FindDeductibleValue = function (provider) {
return self.SelectedDeductibles.findObs('Provider', { Provider: provider }).Value();
}
This function works fine when I call it from the ViewModel, but I get "Cannot read property 'Value' of null at viewModel.self.FindDeductibleValue" when I try to use it in the view/page in the IF statement.
I've replaced $parent.Provider() with a number just to make sure that $parent.Provider() is not null, but it doesn't change the error I receive.
Is it not possible to use a function in an IF statement this way?
The issue here is "binding context". Couple things first though.
EDIT:
I just noticed that the method FindDeductibleValue() receives
something other than the currently iterated item, like knockout does
automatically. And the code within it seems a little strange. Can you
please post the full view models you're working with? I'm not
convinced there's enough context to answer the problem correctly here.
I would use the $parents array not $root in case the depth or pattern ever changes.
You don't need to invoke your observables in your bindings, knockout will do this for you. <!-- ko foreach: ExtendedItems --> instead of <!-- ko foreach: ExtendedItems() -->.
The main error you're encountering is a binding context issue, whereby when invoking the method from within the loop, you are essentially within a child context of the viewmodel. Unfortunately, JavaScript isn't able to tell you this. But it is telling you the problem. The child item doesn't have a Value property. In order to fix this you need to bind to the correct context I believe the code would be:
$parents[0].FindDeductibleValue.bind(null, $parent.Provider())
I want to use variable in html find but in can't find any way to do it. I tried this but not working for me.
<!--ko foreach: { data: test(), as: 'method'}-->
<!--ko var isValid = test_title;
/ko !-->
<tr class="row"><th colspan="4" data-bind="text: isValid" class="test_title"></th></tr>
<!-- /ko !-->
First Experience with KO.
You can't write javascript in a ko comment, but you can write it in the binding value.
I'm trying to use Knockout's afterRender binding, but the function that I reference is never called.
I have nested view-models:
vmConcepts and vmConcept, where vmConcepts.Concepts = array of vmConcept objects.
vmConcept (the inner model) has a function self.Rendered = function (elmnt) {...
I bind vmConcepts (the outer model) to the following markup (you can see that this calls a nested template):
<ul>
<!-- ko template: { name: 'concept-template', foreach: { data: Concepts, afterRender: Rendered } } --><!-- /ko -->
</ul>
My understanding is that this afterRender binding should be called for each vmConcept object (in vmConcepts.Concepts) passed to the concept-template template, but that doesn't happen. I've even added the same Rendered function to vmConcepts and that doesn't get hit either.
I've tried this as both a data-bind binding and as a virtual binding.
What am I missing?
Your bindings are messed up. The foreach inside template isn't the same as the foreach binding. The after rendered on the template will fire after every child.
Try this
<ul>
<!-- ko template: {
name: 'concept-template',
foreach: Concepts,
afterRender: Rendered
} --><!-- /ko -->
</ul>
I have a working example here:
http://jsfiddle.net/4t94G/1/