How to validate inputs dynamically created using ng-repeat, ng-show (angular) - javascript
I have a table that is created using ng-repeat. I want to add validation to each element in the table. The problem is that each input cell has the same name as the cell above and below it. I attempted to use the {{$index}} value to name the inputs, but despite the string literals in HTML appearing correct, it is now working.
Here is my code as of now:
<tr ng-repeat="r in model.BSM ">
<td>
<input ng-model="r.QTY" class="span1" name="QTY{{$index}}" ng-pattern="/^[\d]*\.?[\d]*$/" required/>
<span class="alert-error" ng-show="form.QTY{{$index}}.$error.pattern"><strong>Requires a number.</strong></span>
<span class="alert-error" ng-show="form.QTY{{$index}}.$error.required"><strong>*Required</strong></span>
</td>
</tr>
I have tried removing the {{}} from index, but that does not work either. As of now, the validation property of the input is working correctly, but the error message is not displayed.
Anyone have any suggestions?
Edit: In addition to the great answers below, here is a blog article that covers this issue in more detail: http://www.thebhwgroup.com/blog/2014/08/angularjs-html-form-design-part-2/
Since the question was asked the Angular team has solved this issue by making it possible to dynamically create input names.
With Angular version 1.3 and later you can now do this:
<form name="vm.myForm" novalidate>
<div ng-repeat="p in vm.persons">
<input type="text" name="person_{{$index}}" ng-model="p" required>
<span ng-show="vm.myForm['person_' + $index].$invalid">Enter a name</span>
</div>
</form>
Demo
Angular 1.3 also introduced ngMessages, a more powerful tool for form validation. You can use the same technique with ngMessages:
<form name="vm.myFormNgMsg" novalidate>
<div ng-repeat="p in vm.persons">
<input type="text" name="person_{{$index}}" ng-model="p" required>
<span ng-messages="vm.myFormNgMsg['person_' + $index].$error">
<span ng-message="required">Enter a name</span>
</span>
</div>
</form>
AngularJS relies on input names to expose validation errors.
Unfortunately, as of today, it is not possible (without using a custom directive) to dynamically generate a name of an input. Indeed, checking input docs we can see that the name attribute accepts a string only.
To solve the 'dynamic name' problem you need to create an inner form (see ng-form):
<div ng-repeat="social in formData.socials">
<ng-form name="urlForm">
<input type="url" name="socialUrl" ng-model="social.url">
<span class="alert error" ng-show="urlForm.socialUrl.$error.url">URL error</span>
</ng-form>
</div>
The other alternative would be to write a custom directive for this.
Here is the jsFiddle showing the usage of the ngForm: http://jsfiddle.net/pkozlowski_opensource/XK2ZT/2/
If you don't want to use ng-form you can use a custom directive that will change the form's name attribute. Place this directive as an attribute on the same element as your ng-model.
If you're using other directives in conjunction, be careful that they don't have the "terminal" property set otherwise this function won't be able to run (given that it has a priority of -1).
For example, when using this directive with ng-options, you must run this one line monkeypatch:
https://github.com/AlJohri/bower-angular/commit/eb17a967b7973eb7fc1124b024aa8b3ca540a155
angular.module('app').directive('fieldNameHack', function() {
return {
restrict: 'A',
priority: -1,
require: ['ngModel'],
// the ngModelDirective has a priority of 0.
// priority is run in reverse order for postLink functions.
link: function (scope, iElement, iAttrs, ctrls) {
var name = iElement[0].name;
name = name.replace(/\{\{\$index\}\}/g, scope.$index);
var modelCtrl = ctrls[0];
modelCtrl.$name = name;
}
};
});
I often find it useful to use ng-init to set the $index to a variable name. For example:
<fieldset class='inputs' ng-repeat="question questions" ng-init="qIndex = $index">
This changes your regular expression to:
name = name.replace(/\{\{qIndex\}\}/g, scope.qIndex);
If you have multiple nested ng-repeats, you can now use these variable names instead of $parent.$index.
Definition of "terminal" and "priority" for directives: https://docs.angularjs.org/api/ng/service/$compile#directive-definition-object
Github Comment regarding need for ng-option monkeypatch:
https://github.com/angular/angular.js/commit/9ee2cdff44e7d496774b340de816344126c457b3#commitcomment-6832095
https://twitter.com/aljohri/status/482963541520314369
UPDATE:
You can also make this work with ng-form.
angular.module('app').directive('formNameHack', function() {
return {
restrict: 'A',
priority: 0,
require: ['form'],
compile: function() {
return {
pre: function(scope, iElement, iAttrs, ctrls) {
var parentForm = $(iElement).parent().controller('form');
if (parentForm) {
var formCtrl = ctrls[0];
delete parentForm[formCtrl.$name];
formCtrl.$name = formCtrl.$name.replace(/\{\{\$index\}\}/g, scope.$index);
parentForm[formCtrl.$name] = formCtrl;
}
}
}
}
};
});
Use the ng-form directive inside of the tag in which you are using the ng-repeat directive. You can then use the scope created by the ng-form directive to reference a generic name. For example:
<div class="form-group col-sm-6" data-ng-form="subForm" data-ng-repeat="field in justificationInfo.justifications"">
<label for="{{field.label}}"><h3>{{field.label}}</h3></label>
<i class="icon-valid" data-ng-show="subForm.input.$dirty && subForm.input.$valid"></i>
<i class="icon-invalid" data-ng-show="subForm.input.$dirty && subForm.input.$invalid"></i>
<textarea placeholder="{{field.placeholder}}" class="form-control" id="{{field.label}}" name="input" type="text" rows="3" data-ng-model="field.value" required>{{field.value}}</textarea>
</div>
Credit to: http://www.benlesh.com/2013/03/angular-js-validating-form-elements-in.html
Added more complex example with "custom validation" on the side of controller http://jsfiddle.net/82PX4/3/
<div class='line' ng-repeat='line in ranges' ng-form='lineForm'>
low: <input type='text'
name='low'
ng-pattern='/^\d+$/'
ng-change="lowChanged(this, $index)" ng-model='line.low' />
up: <input type='text'
name='up'
ng-pattern='/^\d+$/'
ng-change="upChanged(this, $index)"
ng-model='line.up' />
<a href ng-if='!$first' ng-click='removeRange($index)'>Delete</a>
<div class='error' ng-show='lineForm.$error.pattern'>
Must be a number.
</div>
<div class='error' ng-show='lineForm.$error.range'>
Low must be less the Up.
</div>
</div>
Looking over these solutions, the one provided by Al Johri above is the closest to my needs, but his directive was a little less programmable then I wanted. Here is my version of his solutions:
angular.module("app", [])
.directive("dynamicFormName", function() {
return {
restrict: "A",
priority: 0,
require: ["form"],
compile: function() {
return {
pre: function preLink(scope, iElement, iAttrs, ctrls) {
var name = "field" + scope.$index;
if (iAttrs.dnfnNameExpression) {
name = scope.$eval(iAttrs.dnfnNameExpression);
}
var parentForm = iElement.parent().controller("form");
if (parentForm) {
var formCtrl = ctrls[0];
delete parentForm[formCtrl.$name];
formCtrl.$name = name;
parentForm[formCtrl.$name] = formCtrl;
}
}
}
}
};
});
This solution lets you just pass a name generator expression to the directive and avoids the lock down to pattern substitution he was using.
I also had trouble initially with this solution since it didn't show an example of using it in markup, so here is how I used it.
<form name="theForm">
<div ng-repeat="field in fields">
<input type="number" ng-form name="theInput{{field.id}}" ng-model="field.value" dynamic-form-name dnfn-name-expression="'theInput' + field.id">
</div>
</form>
I have a more complete working example on github.
validation is working with ng repeat if I use the following syntax scope.step3Form['item[107][quantity]'].$touched
I don't know it's a best practice or the best solution, but it works
<tr ng-repeat="item in items">
<td>
<div class="form-group">
<input type="text" ng-model="item.quantity" name="item[<% item.id%>][quantity]" required="" class="form-control" placeholder = "# of Units" />
<span ng-show="step3Form.$submitted || step3Form['item[<% item.id %>][quantity]'].$touched">
<span class="help-block" ng-show="step3Form['item[<% item.id %>][quantity]'].$error.required"> # of Units is required.</span>
</span>
</div>
</td>
</tr>
Building on pkozlowski.opensource's answer, I've added a way to have dynamic input names that also work with ngMessages. Note the ng-init part on the ng-form element and the use of furryName. furryName becomes the variable name that contains the variable value for the input's name attribute.
<ion-item ng-repeat="animal in creatures track by $index">
<ng-form name="animalsForm" ng-init="furryName = 'furry' + $index">
<!-- animal is furry toggle buttons -->
<input id="furryRadio{{$index}}"
type="radio"
name="{{furryName}}"
ng-model="animal.isFurry"
ng-value="radioBoolValues.boolTrue"
required
>
<label for="furryRadio{{$index}}">Furry</label>
<input id="hairlessRadio{{$index}}"
name="{{furryName}}"
type="radio"
ng-model="animal.isFurry"
ng-value="radioBoolValues.boolFalse"
required
>
<label for="hairlessRadio{{$index}}">Hairless</label>
<div ng-messages="animalsForm[furryName].$error"
class="form-errors"
ng-show="animalsForm[furryName].$invalid && sectionForm.$submitted">
<div ng-messages-include="client/views/partials/form-errors.ng.html"></div>
</div>
</ng-form>
</ion-item>
Here an example of how I do that, I don't know if it is the best solution, but works perfectly.
First, code in HTML.
Look at ng-class, it's calling hasError function.
Look also to the input's name declaration. I use the $index to create different input names.
<div data-ng-repeat="tipo in currentObject.Tipo"
ng-class="{'has-error': hasError(planForm, 'TipoM', 'required', $index) || hasError(planForm, 'TipoM', 'maxlength', $index)}">
<input ng-model="tipo.Nombre" maxlength="100" required
name="{{'TipoM' + $index}}"/>
And now, here is the hasError function:
$scope.hasError = function (form, elementName, errorType, index) {
if (form == undefined
|| elementName == undefined
|| errorType == undefined
|| index == undefined)
return false;
var element = form[elementName + index];
return (element != null && element.$error[errorType] && element.$touched);
};
It is too late but might be it can help anyone
Create unique name for every control
Validate by using fromname[uniquname].$error
Sample code:
<input
ng-model="r.QTY"
class="span1"
name="QTY{{$index}}"
ng-pattern="/^[\d]*\.?[\d]*$/" required/>
<div ng-messages="formName['QTY' +$index].$error"
ng-show="formName['QTY' +$index].$dirty || formName.$submitted">
<div ng-message="required" class='error'>Required</div>
<div ng-message="pattern" class='error'>Invalid Pattern</div>
</div>
See working demo here
If your using ng-repeat $index works like this
name="QTY{{$index}}"
and
<td>
<input ng-model="r.QTY" class="span1" name="QTY{{$index}}" ng-
pattern="/^[\d]*\.?[\d]*$/" required/>
<span class="alert-error" ng-show="form['QTY' + $index].$error.pattern">
<strong>Requires a number.</strong></span>
<span class="alert-error" ng-show="form['QTY' + $index].$error.required">
<strong>*Required</strong></span>
</td>
we have to show the ng-show in ng-pattern
<span class="alert-error" ng-show="form['QTY' + $index].$error.pattern">
<span class="alert-error" ng-show="form['QTY' + $index].$error.required">
It is possible and here is how I do the same thing with a table of inputs.
wrap the table in a form like so
Then just use this
I have a form with multi-nested directives that all contain input(s), select(s), etc...
These elements are all enclosed in ng-repeats, and dynamic string values.
This is how to use the directive:
<form name="myFormName">
<nested directives of many levels>
<your table here>
<perhaps a td here>
ex: <input ng-repeat=(index, variable) in variables" type="text"
my-name="{{ variable.name + '/' + 'myFormName' }}"
ng-model="variable.name" required />
ex: <select ng-model="variable.name" ng-options="label in label in {{ variable.options }}"
my-name="{{ variable.name + index + '/' + 'myFormName' }}"
</select>
</form>
Note: you can add and index to the string concatenation if you need to serialize perhaps a table of inputs; which is what I did.
app.directive('myName', function(){
var myNameError = "myName directive error: "
return {
restrict:'A', // Declares an Attributes Directive.
require: 'ngModel', // ngModelController.
link: function( scope, elem, attrs, ngModel ){
if( !ngModel ){ return } // no ngModel exists for this element
// check myName input for proper formatting ex. something/something
checkInputFormat(attrs);
var inputName = attrs.myName.match('^\\w+').pop(); // match upto '/'
assignInputNameToInputModel(inputName, ngModel);
var formName = attrs.myName.match('\\w+$').pop(); // match after '/'
findForm(formName, ngModel, scope);
} // end link
} // end return
function checkInputFormat(attrs){
if( !/\w\/\w/.test(attrs.rsName )){
throw myNameError + "Formatting should be \"inputName/formName\" but is " + attrs.rsName
}
}
function assignInputNameToInputModel(inputName, ngModel){
ngModel.$name = inputName
}
function addInputNameToForm(formName, ngModel, scope){
scope[formName][ngModel.$name] = ngModel; return
}
function findForm(formName, ngModel, scope){
if( !scope ){ // ran out of scope before finding scope[formName]
throw myNameError + "<Form> element named " + formName + " could not be found."
}
if( formName in scope){ // found scope[formName]
addInputNameToForm(formName, ngModel, scope)
return
}
findForm(formName, ngModel, scope.$parent) // recursively search through $parent scopes
}
});
This should handle many situations where you just don't know where the form will be. Or perhaps you have nested forms, but for some reason you want to attach this input name to two forms up? Well, just pass in the form name you want to attach the input name to.
What I wanted, was a way to assign dynamic values to inputs that I will never know, and then just call $scope.myFormName.$valid.
You can add anything else you wish: more tables more form inputs, nested forms, whatever you want. Just pass the form name you want to validate the inputs against. Then on form submit ask if the $scope.yourFormName.$valid
This will get the name in the ng-repeat to come up seperate in the form validation.
<td>
<input ng-model="r.QTY" class="span1" name="{{'QTY' + $index}}" ng-pattern="/^[\d]*\.?[\d]*$/" required/>
</td>
But I had trouble getting it to look up in its validation message so I had to use an ng-init to get it to resolve a variable as the object key.
<td>
<input ng-model="r.QTY" class="span1" ng-init="name = 'QTY' + $index" name="{{name}}" ng-pattern="/^[\d]*\.?[\d]*$/" required/>
<span class="alert-error" ng-show="form[name].$error.pattern"><strong>Requires a number.</strong></span>
<span class="alert-error" ng-show="form[name].$error.required"><strong>*Required</strong></span>
My requirements were a bit different than the ones asked on the original question, but hopefully I might help someone who is going through the same problem that I was..
I had to define if a field was required or not based on a scope variable.. So I basically had to set ng-required="myScopeVariable" (which is a boolean variable).
<div class="align-left" ng-repeat="schema in schemas">
<input type="text" ng-required="schema.Required" />
</div>
Related
AngularJS apply class to parent element on event?
I have a form field: <div class="form-group"> <label>Name</label> <input type="text" name="name" class="form-control" ng-model="abc.user.name" ng-focus="abc.setFocus('name')" required> </div> What I need to do is set add a class to the parent element, here <div class="form-group">, when the input has focus and remove it when the field loses focus. I know how to do this in jQuery, but not in an Angular way. I have many form fields that need to behave like this, so I'm trying to avoid setting a variable and looking for that with an ng-class. I'd rather have some way for the field to simple act on its parent, which I can use the same method in every form field.
A directive is possibly the simplest generic approach if all you need to do is manipulate the dom. <div class="form-group" focus-class="focused"> <label>Name</label> <input name="name" class="form-control" ng-model="abc.user.name" required> </div> JS angular.module('myApp').directive('focusClass', function(){ return { link:function(scope, elem, attrs){ elem.find('input').on('focus', function(){ elem.toggleClass(attrs.focusClass); }).on('blur', function(){ elem.toggleClass(attrs.focusClass); }); } } });
You can perform this <div class="form-group {{focusIsSet ? 'is-focused': ''}}"> <label>Name</label> <input type="text" name="name" class="form-control" ng-model="abc.user.name" ng-focus="focusIsSet = true" ng-blur="focusIsSet = false" required> </div> Where $scope.focusIsSet a boolean property. So depends of its state you can manage classes in <div class="form-group"> with that expression {{focusIsSet ? 'is-focused': ''}} You change it with ng-focus and ng-blur directives UPDATE I think you can hold states for each input with that way <div class="form-group {{checkFocusState('abc.user.name') ? 'is-focused': ''}}"> <label>Name</label> <input type="text" name="name" class="form-control" ng-model="abc.user.name" ng-focus="setFocus('abc.user.name')" ng-blur="setBlur('abc.user.name')" required> </div> </div> JS code var inputsFocusState = {}; $scope.checkFocusState = function(propertyPathName) { if(inputsFocusState[propertyPathName] == true) { return true; } return false } $scope.setBlur = function(propertyPathName) { inputsFocusState[propertyPathName] = false; } $scope.setFocus = function(propertyPathName) { inputsFocusState[propertyPathName] = true; } Otherwise, you can create each focus property for each input in html template P.S. ng-class is good option too P.S.S I had similar case, but forms were completely dynamic. So I split each property in object like user.name = {value: 'john', buttons: [...], label: 'Name', //and much more}. Also better to change 'user.name.path' to something like 'user-name-path'.
Using Angular to set the html form type
I'm trying to use Angular to display a form that contains all the properties for an object. Some of those objects are passwords and I want angular to use the password form type for those. So far I've gotten it working by setting the type attribute to an angular method, but I'm wondering if there's a cleaner angular syntax for it (like how you can use ng-href instead of href) Sample html code: <form name="siteSettingsForm" novalidate class="form-horizontal" ng-submit="save()"> <div class="form-group" ng-repeat="property in siteProperties"> <label for="{{ property }}" class="control-label col-sm-3">{{ property }}</label> <input id="{{ property }}" type="{{ getPropertyFormType(property) }}" ng-model="site[property]" class="form-control col-sm-9" /> </div> <div> <input type="submit" class="btn btn-primary" value="Save"/> </div> </form> Controller code: app.controller("settingsController", [ '$scope', function ($scope) { $scope.site = { basic_auth_username: "myUsername", basic_auth_password: "hide me" }; $scope.siteProperties = []; for (var property in $scope.site) { if ($scope.site.hasOwnProperty(property)) { $scope.siteProperties.push(property); } } $scope.getPropertyFormType = function(property) { if (property.indexOf("password") > -1) { return "password"; } else { return "text"; } } }]); So question: is there a better way to use Angular to specify the type in the form?
Check out the ng-attr section here. You can use that to decorate the type attribute. Although as you are not allowed to dynamically switch input types anyway, I don't see a clear advantage to using it one way or the other. The way you are doing it (hardcoding when DOM is loaded) will work just fine for your purposes. Depending on the shape of your object, you might be able to clean up your function and just put it straight into your Angular expression in your HTML.
For posterity: I ended up using the method I described in my question
AngularJS directives: Substituting attribute values directly into template
I've been trying to develop an AngularJS directive that outputs a labelled form-field. I'd like to be able to use a tag like the following: <simpleTextField bind="user.email" label="Email" name="email" placeholder="Enter email address"></simpleTextField> This is to produce the following (bootstrap) HTML output: <div class="form-group"> <label class="col-sm-2 control-label" for="email">Email</label> <div class="col-sm-10"> <input type="text" class="form-control" name="email" ng-model="user.email" placeholder="Enter email address"> </div> </div> As you can see the attributes include both an attribute that defines a binding and one whose value is to be substituted directly into the template HTML. I'd like it to be properly encapsulated. In other words, I don't want to have to modify the view's controller in order to accommodate usage of this directive. None of the examples I've seen satisfy my requirements because (1) they don't substitute the attribute values directly into the template, and/or (2) they rely on the controller of the view in which the directive is being used to be modified. Please note that I'm new to AngularJS so I may be completely off track here.
I think I have made something that should work. You can pass in values to directly bind to the template and the directive has no knowledge of the parent's model. The HTML + directive: <div ng-controller="MyCtrl"> <label>Parent Scope Email:{{email}}</label></br> <simple-text-field simple-bind-to="email" simple-label="Email" simple-name="email" simple-placeholder="Enter email address" simple-dynamic-scope="user.email"> </simple-text-field> </div> The directive: var myApp = angular.module('myApp',[]); myApp.directive('simpleTextField', function() { return { restrict: 'E', scope: { simpleBindTo: "=", simpleLabel: "#simpleLabel", simpleName: "#simpleName", simplePlaceholder: "#simplePlaceholder", }, template: '<div class="form-group">' + ' <label class="col-sm-2 control-label" for="{{simpleName}}">{{simpleLabel}}</label>' + ' <div class="col-sm-10">' + ' <input type="text" class="form-control" name="{{simpleName}}" ' + ' placeholder="{{simplePlaceholder}}" ng-model="simpleBindTo" >' + ' </div>' + '</div>' }; }); myApp.controller('MyCtrl', function ($scope) { $scope.email = ''; }); By using the '=' access modifier, the ng-model can be assigned variable member of the parent scope, without the directive knowing anything about this variable. Here is a jsfiddle for the above example.
Angular get form elements
I am trying to get element name and class from a form that is passed on to a function. How can i do that? Html side. <form name="test"> <div> <input type="text" class="test1" name="test2"/> </div> <div> <input type="text" class="test3" name="test4"/> </div> </form> <div> <input type="button" data-ng-click="save(test)" /> </div> and Javascript side $scope.save = function(form){ for(how many elements are there) (get elements values) } how can I do that, can it even be done like that? My purpose is to change class and some other attributes when it's necessary.
You can access the form directly from $scope using its name, i.e. $scope.test, and the elements from the form, e.g. $scope.test.test2. However, if you want to loop through the elements without having to know their individual names you can do something like: angular.forEach($scope.test, function (element, name) { if (!name.startsWith('$')) { // element is a form element! } });
I'm relatively new to AngularJS, but I am going to make a solid attempt to answer to test my knowledge and hopefully help you. So in your form, on each of your elements you should use a ng-model. For example, here is a form that may collect a users first and last name: <form name="test"> <div> <input type="text" class="test1" name="test2" data-ng-model="user.name/> </div> <div> <input type="text" class="test3" name="test4" data-ng-model="user.last/> </div> </form> <div> <input type="button" data-ng-click="save(test)" /> </div> This will allow you to access the data in your form through $scope.user. Now for changing classes and attributes, I'm not sure what rules dictate a class/attribute change on your form, but you could use the ng-dirty class as a "flag" to watch for when the user makes a change. Some more information here as to what exactly you are trying to accomplish would be helpful.
A common piece of advice I've seen for angular.js is that, you should only do DOM manipulation in directives, so you should definitely consider doing it according to Anthony's answer, that is, using ng-model. Go down below to see a way to do it more properly using directives. But if you insist on doing it in the controller, here is a jsfidle that shows you how you can approach it: http://jsfiddle.net/3BBbc/2/ HTML: <body ng-app="myApp"> <div ng-controller="MyCtrl"> <form id="test"> <div> <input type="text" class="test1" name="test2" /> </div> <div> <input type="text" class="test3" name="test4" /> </div> </form> <div> <input type="button" ng-click="save('test')" value="submit" /> </div> </div> </body> JavaScript: var myApp = angular.module('myApp', []); function MyCtrl($scope) { $scope.save = function (formId) { $('#' + formId).find('input').each(function (idx, input) { // Do your DOM manipulation here console.log($(input).val()); }); }; } And here is the jsfiddle showing you how to do it with directives. It's a bit more complicated though...: http://jsfiddle.net/3BBbc/5/
I am trying to get element name and class from a form that is passed on to a function. How can i do that? Your pseudocode is on the right track: $scope.save = function( formName ) { angular.forEach( $scope[ formName ], function( field, fieldName ) { // Ignore Angular properties; we only want form fields if( fieldName[ 0 ] === '$' ) { return; } // "fieldName" contains the name of the field // Get the value var fieldValue = field.$viewValue; } ); } My purpose is to change class and some other attributes when it's necessary. To do that, you can get the field elements, with the Angular element wrapper: // Get the field element, as an Angular element var fieldElement = angular.element( document.querySelector( '[name="' + fieldName + '"]' ) ); You can then use various jqLite methods on these elements. For instance, to set the element's class (overwriting the existing class), you can use the attr method: // Replace existing class with "new-class" fieldElement.attr( 'class', 'new-class' );
Dynamic input name attribute in angularjs ng-repeat [duplicate]
I have a table that is created using ng-repeat. I want to add validation to each element in the table. The problem is that each input cell has the same name as the cell above and below it. I attempted to use the {{$index}} value to name the inputs, but despite the string literals in HTML appearing correct, it is now working. Here is my code as of now: <tr ng-repeat="r in model.BSM "> <td> <input ng-model="r.QTY" class="span1" name="QTY{{$index}}" ng-pattern="/^[\d]*\.?[\d]*$/" required/> <span class="alert-error" ng-show="form.QTY{{$index}}.$error.pattern"><strong>Requires a number.</strong></span> <span class="alert-error" ng-show="form.QTY{{$index}}.$error.required"><strong>*Required</strong></span> </td> </tr> I have tried removing the {{}} from index, but that does not work either. As of now, the validation property of the input is working correctly, but the error message is not displayed. Anyone have any suggestions? Edit: In addition to the great answers below, here is a blog article that covers this issue in more detail: http://www.thebhwgroup.com/blog/2014/08/angularjs-html-form-design-part-2/
Since the question was asked the Angular team has solved this issue by making it possible to dynamically create input names. With Angular version 1.3 and later you can now do this: <form name="vm.myForm" novalidate> <div ng-repeat="p in vm.persons"> <input type="text" name="person_{{$index}}" ng-model="p" required> <span ng-show="vm.myForm['person_' + $index].$invalid">Enter a name</span> </div> </form> Demo Angular 1.3 also introduced ngMessages, a more powerful tool for form validation. You can use the same technique with ngMessages: <form name="vm.myFormNgMsg" novalidate> <div ng-repeat="p in vm.persons"> <input type="text" name="person_{{$index}}" ng-model="p" required> <span ng-messages="vm.myFormNgMsg['person_' + $index].$error"> <span ng-message="required">Enter a name</span> </span> </div> </form>
AngularJS relies on input names to expose validation errors. Unfortunately, as of today, it is not possible (without using a custom directive) to dynamically generate a name of an input. Indeed, checking input docs we can see that the name attribute accepts a string only. To solve the 'dynamic name' problem you need to create an inner form (see ng-form): <div ng-repeat="social in formData.socials"> <ng-form name="urlForm"> <input type="url" name="socialUrl" ng-model="social.url"> <span class="alert error" ng-show="urlForm.socialUrl.$error.url">URL error</span> </ng-form> </div> The other alternative would be to write a custom directive for this. Here is the jsFiddle showing the usage of the ngForm: http://jsfiddle.net/pkozlowski_opensource/XK2ZT/2/
If you don't want to use ng-form you can use a custom directive that will change the form's name attribute. Place this directive as an attribute on the same element as your ng-model. If you're using other directives in conjunction, be careful that they don't have the "terminal" property set otherwise this function won't be able to run (given that it has a priority of -1). For example, when using this directive with ng-options, you must run this one line monkeypatch: https://github.com/AlJohri/bower-angular/commit/eb17a967b7973eb7fc1124b024aa8b3ca540a155 angular.module('app').directive('fieldNameHack', function() { return { restrict: 'A', priority: -1, require: ['ngModel'], // the ngModelDirective has a priority of 0. // priority is run in reverse order for postLink functions. link: function (scope, iElement, iAttrs, ctrls) { var name = iElement[0].name; name = name.replace(/\{\{\$index\}\}/g, scope.$index); var modelCtrl = ctrls[0]; modelCtrl.$name = name; } }; }); I often find it useful to use ng-init to set the $index to a variable name. For example: <fieldset class='inputs' ng-repeat="question questions" ng-init="qIndex = $index"> This changes your regular expression to: name = name.replace(/\{\{qIndex\}\}/g, scope.qIndex); If you have multiple nested ng-repeats, you can now use these variable names instead of $parent.$index. Definition of "terminal" and "priority" for directives: https://docs.angularjs.org/api/ng/service/$compile#directive-definition-object Github Comment regarding need for ng-option monkeypatch: https://github.com/angular/angular.js/commit/9ee2cdff44e7d496774b340de816344126c457b3#commitcomment-6832095 https://twitter.com/aljohri/status/482963541520314369 UPDATE: You can also make this work with ng-form. angular.module('app').directive('formNameHack', function() { return { restrict: 'A', priority: 0, require: ['form'], compile: function() { return { pre: function(scope, iElement, iAttrs, ctrls) { var parentForm = $(iElement).parent().controller('form'); if (parentForm) { var formCtrl = ctrls[0]; delete parentForm[formCtrl.$name]; formCtrl.$name = formCtrl.$name.replace(/\{\{\$index\}\}/g, scope.$index); parentForm[formCtrl.$name] = formCtrl; } } } } }; });
Use the ng-form directive inside of the tag in which you are using the ng-repeat directive. You can then use the scope created by the ng-form directive to reference a generic name. For example: <div class="form-group col-sm-6" data-ng-form="subForm" data-ng-repeat="field in justificationInfo.justifications""> <label for="{{field.label}}"><h3>{{field.label}}</h3></label> <i class="icon-valid" data-ng-show="subForm.input.$dirty && subForm.input.$valid"></i> <i class="icon-invalid" data-ng-show="subForm.input.$dirty && subForm.input.$invalid"></i> <textarea placeholder="{{field.placeholder}}" class="form-control" id="{{field.label}}" name="input" type="text" rows="3" data-ng-model="field.value" required>{{field.value}}</textarea> </div> Credit to: http://www.benlesh.com/2013/03/angular-js-validating-form-elements-in.html
Added more complex example with "custom validation" on the side of controller http://jsfiddle.net/82PX4/3/ <div class='line' ng-repeat='line in ranges' ng-form='lineForm'> low: <input type='text' name='low' ng-pattern='/^\d+$/' ng-change="lowChanged(this, $index)" ng-model='line.low' /> up: <input type='text' name='up' ng-pattern='/^\d+$/' ng-change="upChanged(this, $index)" ng-model='line.up' /> <a href ng-if='!$first' ng-click='removeRange($index)'>Delete</a> <div class='error' ng-show='lineForm.$error.pattern'> Must be a number. </div> <div class='error' ng-show='lineForm.$error.range'> Low must be less the Up. </div> </div>
Looking over these solutions, the one provided by Al Johri above is the closest to my needs, but his directive was a little less programmable then I wanted. Here is my version of his solutions: angular.module("app", []) .directive("dynamicFormName", function() { return { restrict: "A", priority: 0, require: ["form"], compile: function() { return { pre: function preLink(scope, iElement, iAttrs, ctrls) { var name = "field" + scope.$index; if (iAttrs.dnfnNameExpression) { name = scope.$eval(iAttrs.dnfnNameExpression); } var parentForm = iElement.parent().controller("form"); if (parentForm) { var formCtrl = ctrls[0]; delete parentForm[formCtrl.$name]; formCtrl.$name = name; parentForm[formCtrl.$name] = formCtrl; } } } } }; }); This solution lets you just pass a name generator expression to the directive and avoids the lock down to pattern substitution he was using. I also had trouble initially with this solution since it didn't show an example of using it in markup, so here is how I used it. <form name="theForm"> <div ng-repeat="field in fields"> <input type="number" ng-form name="theInput{{field.id}}" ng-model="field.value" dynamic-form-name dnfn-name-expression="'theInput' + field.id"> </div> </form> I have a more complete working example on github.
validation is working with ng repeat if I use the following syntax scope.step3Form['item[107][quantity]'].$touched I don't know it's a best practice or the best solution, but it works <tr ng-repeat="item in items"> <td> <div class="form-group"> <input type="text" ng-model="item.quantity" name="item[<% item.id%>][quantity]" required="" class="form-control" placeholder = "# of Units" /> <span ng-show="step3Form.$submitted || step3Form['item[<% item.id %>][quantity]'].$touched"> <span class="help-block" ng-show="step3Form['item[<% item.id %>][quantity]'].$error.required"> # of Units is required.</span> </span> </div> </td> </tr>
Building on pkozlowski.opensource's answer, I've added a way to have dynamic input names that also work with ngMessages. Note the ng-init part on the ng-form element and the use of furryName. furryName becomes the variable name that contains the variable value for the input's name attribute. <ion-item ng-repeat="animal in creatures track by $index"> <ng-form name="animalsForm" ng-init="furryName = 'furry' + $index"> <!-- animal is furry toggle buttons --> <input id="furryRadio{{$index}}" type="radio" name="{{furryName}}" ng-model="animal.isFurry" ng-value="radioBoolValues.boolTrue" required > <label for="furryRadio{{$index}}">Furry</label> <input id="hairlessRadio{{$index}}" name="{{furryName}}" type="radio" ng-model="animal.isFurry" ng-value="radioBoolValues.boolFalse" required > <label for="hairlessRadio{{$index}}">Hairless</label> <div ng-messages="animalsForm[furryName].$error" class="form-errors" ng-show="animalsForm[furryName].$invalid && sectionForm.$submitted"> <div ng-messages-include="client/views/partials/form-errors.ng.html"></div> </div> </ng-form> </ion-item>
Here an example of how I do that, I don't know if it is the best solution, but works perfectly. First, code in HTML. Look at ng-class, it's calling hasError function. Look also to the input's name declaration. I use the $index to create different input names. <div data-ng-repeat="tipo in currentObject.Tipo" ng-class="{'has-error': hasError(planForm, 'TipoM', 'required', $index) || hasError(planForm, 'TipoM', 'maxlength', $index)}"> <input ng-model="tipo.Nombre" maxlength="100" required name="{{'TipoM' + $index}}"/> And now, here is the hasError function: $scope.hasError = function (form, elementName, errorType, index) { if (form == undefined || elementName == undefined || errorType == undefined || index == undefined) return false; var element = form[elementName + index]; return (element != null && element.$error[errorType] && element.$touched); };
It is too late but might be it can help anyone Create unique name for every control Validate by using fromname[uniquname].$error Sample code: <input ng-model="r.QTY" class="span1" name="QTY{{$index}}" ng-pattern="/^[\d]*\.?[\d]*$/" required/> <div ng-messages="formName['QTY' +$index].$error" ng-show="formName['QTY' +$index].$dirty || formName.$submitted"> <div ng-message="required" class='error'>Required</div> <div ng-message="pattern" class='error'>Invalid Pattern</div> </div> See working demo here
If your using ng-repeat $index works like this name="QTY{{$index}}" and <td> <input ng-model="r.QTY" class="span1" name="QTY{{$index}}" ng- pattern="/^[\d]*\.?[\d]*$/" required/> <span class="alert-error" ng-show="form['QTY' + $index].$error.pattern"> <strong>Requires a number.</strong></span> <span class="alert-error" ng-show="form['QTY' + $index].$error.required"> <strong>*Required</strong></span> </td> we have to show the ng-show in ng-pattern <span class="alert-error" ng-show="form['QTY' + $index].$error.pattern"> <span class="alert-error" ng-show="form['QTY' + $index].$error.required">
It is possible and here is how I do the same thing with a table of inputs. wrap the table in a form like so Then just use this I have a form with multi-nested directives that all contain input(s), select(s), etc... These elements are all enclosed in ng-repeats, and dynamic string values. This is how to use the directive: <form name="myFormName"> <nested directives of many levels> <your table here> <perhaps a td here> ex: <input ng-repeat=(index, variable) in variables" type="text" my-name="{{ variable.name + '/' + 'myFormName' }}" ng-model="variable.name" required /> ex: <select ng-model="variable.name" ng-options="label in label in {{ variable.options }}" my-name="{{ variable.name + index + '/' + 'myFormName' }}" </select> </form> Note: you can add and index to the string concatenation if you need to serialize perhaps a table of inputs; which is what I did. app.directive('myName', function(){ var myNameError = "myName directive error: " return { restrict:'A', // Declares an Attributes Directive. require: 'ngModel', // ngModelController. link: function( scope, elem, attrs, ngModel ){ if( !ngModel ){ return } // no ngModel exists for this element // check myName input for proper formatting ex. something/something checkInputFormat(attrs); var inputName = attrs.myName.match('^\\w+').pop(); // match upto '/' assignInputNameToInputModel(inputName, ngModel); var formName = attrs.myName.match('\\w+$').pop(); // match after '/' findForm(formName, ngModel, scope); } // end link } // end return function checkInputFormat(attrs){ if( !/\w\/\w/.test(attrs.rsName )){ throw myNameError + "Formatting should be \"inputName/formName\" but is " + attrs.rsName } } function assignInputNameToInputModel(inputName, ngModel){ ngModel.$name = inputName } function addInputNameToForm(formName, ngModel, scope){ scope[formName][ngModel.$name] = ngModel; return } function findForm(formName, ngModel, scope){ if( !scope ){ // ran out of scope before finding scope[formName] throw myNameError + "<Form> element named " + formName + " could not be found." } if( formName in scope){ // found scope[formName] addInputNameToForm(formName, ngModel, scope) return } findForm(formName, ngModel, scope.$parent) // recursively search through $parent scopes } }); This should handle many situations where you just don't know where the form will be. Or perhaps you have nested forms, but for some reason you want to attach this input name to two forms up? Well, just pass in the form name you want to attach the input name to. What I wanted, was a way to assign dynamic values to inputs that I will never know, and then just call $scope.myFormName.$valid. You can add anything else you wish: more tables more form inputs, nested forms, whatever you want. Just pass the form name you want to validate the inputs against. Then on form submit ask if the $scope.yourFormName.$valid
This will get the name in the ng-repeat to come up seperate in the form validation. <td> <input ng-model="r.QTY" class="span1" name="{{'QTY' + $index}}" ng-pattern="/^[\d]*\.?[\d]*$/" required/> </td> But I had trouble getting it to look up in its validation message so I had to use an ng-init to get it to resolve a variable as the object key. <td> <input ng-model="r.QTY" class="span1" ng-init="name = 'QTY' + $index" name="{{name}}" ng-pattern="/^[\d]*\.?[\d]*$/" required/> <span class="alert-error" ng-show="form[name].$error.pattern"><strong>Requires a number.</strong></span> <span class="alert-error" ng-show="form[name].$error.required"><strong>*Required</strong></span>
My requirements were a bit different than the ones asked on the original question, but hopefully I might help someone who is going through the same problem that I was.. I had to define if a field was required or not based on a scope variable.. So I basically had to set ng-required="myScopeVariable" (which is a boolean variable). <div class="align-left" ng-repeat="schema in schemas"> <input type="text" ng-required="schema.Required" /> </div>